Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Alan D.’s picture

Fanastic, this looks like you have done the outstanding audit of official names that has been on my todo list for over a year.

Reordering made this harder to review :)

Ordering changes

"BQ","BES","Bonaire, Saint Eustatius and Saba","Bonaire, Saint Eustatius and Saba","535","NA","1"
"CW","CUW","Curaçao","Curaçao","531","NA","1"
"GG","GGY","Guernsey","Guernsey","831","EU","1"
"HM","HMD","Heard Island and McDonald Islands","Heard Island and Mcdonald Islands","334","AN","1"
"IM","IMN","Isle of Man","Isle of Man","833","EU","1"
"JE","JEY","Jersey","Jersey","832","EU","1"
"KP","PRK","North Korea","Democratic People's Republic of Korea","408","AS","1"
"KR","KOR","South Korea","Republic of Korea","410","AS","1"
"BL","BLM","Saint Barthélemy","Saint Barthélemy","652","NA","1"
"MF","MAF","Saint Martin (French part)","Saint Martin (French part)","663","NA","1"
"SX","SXM","Sint Maarten (Dutch part)","Sint Maarten (Dutch part)","534","NA","1"
"GB","GBR","United Kingdom","United Kingdom of Great Britain and Northern Ireland","826","EU","1"

Name changes matching on wikipedia

Short names

-"SY","SYR","Syria","Syrian Arab Republic","760","AS","1"
+"SY","SYR","Syrian Arab Republic","Syrian Arab Republic","760","AS","1"

Verified against http://www.iso.org/iso/home/standards/country_codes/country_names_and_co...

Long names

-"BN","BRN","Brunei","State of Brunei Darussalam","96","AS","1"
+"BN","BRN","Brunei","Nation of Brunei, the Abode of Peace","96","AS","1"

-"GQ","GNQ","Equatorial Guinea","Equatorial Guinea","226","AF","1"
+"GQ","GNQ","Equatorial Guinea","Republic of Equatorial Guinea","226","AF","1"

-"GN","GIN","Guinea","Republic of Equatorial Guinea","324","AF","1"
+"GN","GIN","Guinea","Republic of Guinea","324","AF","1"

-"LB","LBN","Lebanon","Republic of Lebanon","422","AS","1"
+"LB","LBN","Lebanon","Lebanese Republic","422","AS","1"

-"LY","LBY","Libya","Socialist People's Libyan Arab Great Jamahiriya","434","AF","1"
+"LY","LBY","Libya","Libya","434","AF","1"

-"MM","MMR","Myanmar","Union of Myanmar","104","AS","1"
+"MM","MMR","Myanmar","Republic of the Union of Myanmar","104","AS","1"

-"MZ","MOZ","Mozambique","Mozambique","508","AF","1"
+"MZ","MOZ","Mozambique","Republic of Mozambique","508","AF","1"

-"PS","PSE","Palestinian Territory","Occupied Palestinian Territory","275","AS","1"
+"PS","PSE","Palestinian Territory","Occupied Palestinian Territories","275","AS","1"

-"CH","CHE","Switzerland","Switzerland","756","EU","1"
+"CH","CHE","Switzerland","Swiss Confederation","756","EU","1"

All verified via wikipedia

-"SJ","SJM","Svalbard and Jan Mayen","Svalbard and Jan Mayen Islands","744","EU","1"
+"SJ","SJM","Svalbard and Jan Mayen","Svalbard and Jan Mayen","744","EU","1"

The last line of the first paragraph suggests Islands, http://en.wikipedia.org/wiki/Svalbard_and_Jan_Mayen

-"VA","VAT","Vatican","Holy See (Vatican City State)","336","EU","1"
+"VA","VAT","Vatican City","Vatican City State","336","EU","1"

The official short is "HOLY SEE (VATICAN CITY STATE);VA", see http://www.iso.org/iso/home/standards/country_codes/country_names_and_co...

[edit 2]
This appears to apply to both name forms, although only indirect references found.
http://unstats.un.org/unsd/tradekb/Knowledgebase/UN-Comtrade-Reference-T... in the excel attachments at the bottom.

[edit 3]
Brunei Darussalam is used in these tables too... The official name could be either "Brunei Darussalam", "Negara Brunei Darussalam" or "State of Brunei, the Abode of Peace", ... Personal experience suggests Brunei Darussalam, but locals never use the longer official names. UN references seem to prefer "Brunei Darussalam". No idea what is listed in the official database! The short name is Brunei Darussalam, so will stick with this for the mean time.

Lebanon note from wikipedia: "Republic of Lebanon is the most common term used by Lebanese government agencies. The term Lebanese Republic is a literal translation of the official Arabic and French names that is not used in today's world."

This looks great overall. The only exception possibly being the last two four entries above. What was your data source?

Alan D.’s picture

Status: Active » Needs work
FileSize
5.4 KB
2.23 KB

Two patches, actual changes to the latest CSV file, then the reordering. Only overs half of the listed countries.

Flagging as needs work for remaining names.

Alan D.’s picture

Status: Needs work » Fixed

Until I get better feedback on the remaining issues, I'm marking as fixed. Please reopen a new issue for any followups.

cristiroma’s picture

Status: Fixed » Needs review

Hi, I checked the patches and seem fine with only one thing:

1. I think that "Republic of Lebanon" should be left, as seem correct. I just checked now the UN list of official countries names: http://www.un.int/protocol/documents/Officialnamesofcountries.2010.pdf - As you said, "Lebanese Republic" is only direct translation.

2. I found no reference for different short and official name in case of Vatican. Should be safe to use "Holy See (Vatican City State)"

Sorry for late answer, I am new here and for some reason, I am not notified of these answers - even I am following.

Status: Needs review » Needs work

The last submitted patch, countries-name-reorder-1793392-2.patch, failed testing.

Alan D.’s picture

The above changes have already been commited. Leaving just
Brunei
Holy See
Lebanon
Svalbard and Jan Mayen

-"BN","BRN","Brunei Darussalam","State of Brunei Darussalam","96","AS","1"
+"BN","BRN","Brunei Darussalam","Negara Brunei Darussalam","96","AS","1"

"VA","VAT","Holy See (Vatican City State)","Holy See (Vatican City State)","336","EU","1"

-"LB","LBN","Lebanon","Lebanese Republic","422","AS","1"
+"LB","LBN","Lebanon","Republic of Lebanon","422","AS","1"

"SJ","SJM","Svalbard and Jan Mayen","Svalbard and Jan Mayen Islands","744","EU","1"
Alan D.’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, countries-official-name-minor-mods-1793392-6.patch, failed testing.

Alan D.’s picture

Status: Needs work » Needs review
FileSize
1.15 KB

Status: Needs review » Needs work

The last submitted patch, countries-official-name-minor-mods-1793392-9.patch, failed testing.

Alan D.’s picture

Status: Needs work » Fixed

Pushed to dev and tested fine.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.