Files: 
CommentFileSizeAuthor
#24 interdiff.txt688 bytesdcam
#24 1797200-24-t-node.patch60.56 KBdcam
PASSED: [[SimpleTest]]: [MySQL] 39,956 pass(es).
[ View ]
#22 1797200-22-t-node.patch60.03 KBdcam
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1797200-22-t-node.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#19 1797200-19-t-node.patch60.03 KBdcam
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1797200-19-t-node.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#17 1797200-17-t-node.patch59.68 KBdcam
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1797200-17-t-node.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#13 1797200-13-t-node.patch60.02 KBdcam
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1797200-13-t-node.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#8 1797200-8-t-node.patch16.79 KBLars Toomre
PASSED: [[SimpleTest]]: [MySQL] 42,669 pass(es).
[ View ]
#8 interdiff-1797200-6-8.txt1.89 KBLars Toomre
#6 1797200-6-t-node.patch15.72 KBLars Toomre
PASSED: [[SimpleTest]]: [MySQL] 42,093 pass(es).
[ View ]
#2 node-1797200-1.patch58.52 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 41,695 pass(es).
[ View ]

Comments

Assigned:Unassigned» xjm

Assigned:xjm» Unassigned
Status:Active» Needs review
StatusFileSize
new58.52 KB
PASSED: [[SimpleTest]]: [MySQL] 41,695 pass(es).
[ View ]

Just the simple string messages. You can use git diff --color-words with the patch applied locally for easier review.

Status:Needs review» Reviewed & tested by the community

I have reviewed each of the straight t() removals from the assert messages in the #2 patch. All are correct and appropriate. I will leave checking for completeness to the follow-up patch correcting t() to format_string() conversions.

With the bot being green, this is RTBC!

Assigned:Unassigned» jhodgdon

Assigned:jhodgdon» Unassigned
Status:Reviewed & tested by the community» Active

Committed the patch in #2 to 8.x. Leaving this issue open for follow-ups for t() -> format_string().

Status:Active» Needs review
StatusFileSize
new15.72 KB
PASSED: [[SimpleTest]]: [MySQL] 42,093 pass(es).
[ View ]

Here is an untested patch that completes the removal of t() from the node test assert messages or, if appropriate, the conversion of t() to format_string().

With this patch applied, I do not observe any more case of t() being used in node tests using grep. This patch includes the final 27 conversions in this module.

Status:Needs review» Needs work

I tested #6 and found two more t()'s around assert messages in NodeRevisionsTest.php on lines 87 and 99.

I could alter the patch myself, but then then we'll have to wait for someone else to test it. @Lars Toomre, if you can make the changes then I'll be sure to come back and re-test. Then we can get this committed.

Status:Needs work» Needs review
StatusFileSize
new1.89 KB
new16.79 KB
PASSED: [[SimpleTest]]: [MySQL] 42,669 pass(es).
[ View ]

Here is a patch that includes the two items noted in #7.

Status:Needs review» Reviewed & tested by the community

I've verified that #8 removes the two t()'s found in #7. I can't find any others that were missed. The patch looks good to me. Marking as RTBC.

Assigned:Unassigned» jhodgdon

Tum te tum...

Version:8.x-dev» 7.x-dev
Assigned:jhodgdon» Unassigned
Status:Reviewed & tested by the community» Patch (to be ported)

Thanks, that one's in! Looks like we need to port #2 + #8.

Thanks @jhodgdon for the review and commit. It is so nice to see the node Tests now complete for D8. Thanks!!

Status:Patch (to be ported)» Needs review
StatusFileSize
new60.02 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1797200-13-t-node.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Backported #2 and #8 to D7.

Status:Needs review» Needs work

The last submitted patch, 1797200-13-t-node.patch, failed testing.

Status:Needs work» Needs review

#13: 1797200-13-t-node.patch queued for re-testing.

Status:Needs review» Needs work

The last submitted patch, 1797200-13-t-node.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new59.68 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1797200-17-t-node.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

I'm not sure why #13 wasn't applying, but I re-backported #2 and #8 to try and get a good patch this time.

Status:Needs review» Needs work

The last submitted patch, 1797200-17-t-node.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new60.03 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1797200-19-t-node.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Let's try this again. I rolled this one on a different system. Maybe I did something to node.test on that other laptop that's causing #13 and #17 to not apply.

Backport of #2 and #8 to D7.

#19: 1797200-19-t-node.patch queued for re-testing.

Status:Needs review» Needs work

The last submitted patch, 1797200-19-t-node.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new60.03 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1797200-22-t-node.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

I rerolled the patch in #19.

Status:Needs review» Needs work

The last submitted patch, 1797200-22-t-node.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new60.56 KB
PASSED: [[SimpleTest]]: [MySQL] 39,956 pass(es).
[ View ]
new688 bytes

#22 had the same problem described in #19. Sorry about that.

I rerolled #17 again and changed another unneeded t(). The post-reroll change is shown in interdiff.txt.

Issue tags:+Novice

Tagging as Novice.

Status:Needs review» Reviewed & tested by the community

Assigned:Unassigned» jhodgdon

Thanks! Assigning to me to commit unless someone else beats me to it.

Assigned:jhodgdon» Unassigned
Status:Reviewed & tested by the community» Fixed

Thanks all! This one is committed to 7.x. Another one of these closed!

Automatically closed -- issue fixed for 2 weeks with no activity.