Files: 
CommentFileSizeAuthor
#10 interdiff.txt540 bytesdcam
#10 1797286-10-forum-t.patch13.28 KBdcam
PASSED: [[SimpleTest]]: [MySQL] 40,211 pass(es).
[ View ]
#6 1797286-6-forum-t.patch13.28 KBdcam
PASSED: [[SimpleTest]]: [MySQL] 40,331 pass(es).
[ View ]
#1 forum-1797286-1.patch13.74 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 41,703 pass(es).
[ View ]

Comments

Title:Remove t() from asserts messages in tests for the forum moduleRemove t() from assertion messages in tests for the forum module
Assigned:xjm» Unassigned
Status:Active» Needs review
Issue tags:+needs backport to D7
StatusFileSize
new13.74 KB
PASSED: [[SimpleTest]]: [MySQL] 41,703 pass(es).
[ View ]

I had to reformat one of the format_string() replacement lines here because it had so many parens that I couldn't read it myself.

Status:Needs review» Reviewed & tested by the community

I have reviewed each of the changes in this patch and each one of the removal/conversion of t() from test asserts is correct.

With the bot being green, this issue is RTBC!

Status:Reviewed & tested by the community» Fixed

Committed to 8.x. Thanks.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Version:8.x-dev» 7.x-dev
Status:Closed (fixed)» Patch (to be ported)

This never made it into Drupal 7.

Status:Patch (to be ported)» Needs review
StatusFileSize
new13.28 KB
PASSED: [[SimpleTest]]: [MySQL] 40,331 pass(es).
[ View ]

Backported #1 to D7.

#6: 1797286-6-forum-t.patch queued for re-testing.

-    $this->assertRaw(theme('breadcrumb', array('breadcrumb' => $breadcrumb)), t('Breadcrumbs were displayed'));
+    $this->assertRaw(theme('breadcrumb', array('breadcrumb' => $breadcrumb)), ('Breadcrumbs were displayed'));

No need for parentheses here, otherwise it's all fine.

Status:Needs review» Needs work

Status:Needs work» Needs review
StatusFileSize
new13.28 KB
PASSED: [[SimpleTest]]: [MySQL] 40,211 pass(es).
[ View ]
new540 bytes

Fixed the issue pointed out in #8.

Status:Needs review» Reviewed & tested by the community

Thanks @dcam, this too is good to go. RTBC.

Status:Reviewed & tested by the community» Fixed

Thanks all! This has been committed to 7.x. Only about 4 more to go!

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Removing myself from the author field so I can unfollow. --xjm