Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Posted by xjm
Part of meta #500866: [META] remove t() from assert message.
Comment | File | Size | Author |
---|---|---|---|
#13 | 1797330-13-t-help.patch | 2.77 KB | dcam |
#9 | 1797330-9-t-help.patch | 1.08 KB | Lars Toomre |
#5 | help-1797330-3.patch | 2.84 KB | xjm |
#5 | interdiff.txt | 846 bytes | xjm |
#1 | help-1797330-1.patch | 2.84 KB | xjm |
Comments
Comment #1
xjmVery little to clean up, but I cleaned up a couple that were using
t()
around weird string concatenation (and nonsense square brackets) to instead useformat_string()
with proper italicized placeholders.Comment #2
xjmOops.
Comment #3
xjmxjm sighs.
Comment #5
xjmDerp.
Comment #6
Lars Toomre CreditAttribution: Lars Toomre commentedOh this one was short and easy...
All of the changes in this patch are correct and appropriate. It includes format_string() changes which also were good.
Hence RTBC!
Comment #7
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks!
Comment #8
jhodgdonThis needs backporting to D7. Also, can someone confirm everything was fixed in D8 and move this back there if not?
Comment #9
Lars Toomre CreditAttribution: Lars Toomre commentedReviewing the resulting help test messages by hand, I see that we missed on t() removal. Attached is a patch that needs to be attached to D8 before backport.
Comment #10
dcam CreditAttribution: dcam commentedI tested #9. I didn't find any other t()'s around Help module test assert messages. Marking as RTBC.
Comment #11
webchickTum te tum...
Comment #12
jhodgdonThanks! That one's in; back to backport (#5 + #9).
Comment #13
dcam CreditAttribution: dcam commentedBackported #5 and #9 to D7.
Comment #14
dcam CreditAttribution: dcam commented#13: 1797330-13-t-help.patch queued for re-testing.
Comment #15
dcam CreditAttribution: dcam commentedTagging as Novice.
Comment #16
jhodgdon#13: 1797330-13-t-help.patch queued for re-testing.
Comment #17
lazysoundsystem CreditAttribution: lazysoundsystem commentedThis looks good. RTBC.
Comment #18
jhodgdonThanks again all! Committed to 7.x.
Comment #19.0
(not verified) CreditAttribution: commentedRemoving myself from the author field so I can unfollow. --xjm