Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Part of meta #500866: [META] remove t() from assert message.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | remove_t_from_openid_testsD7-1797370-9.patch | 29.95 KB | lazysoundsystem |
| #9 | openid_tests_interdiff.txt | 596 bytes | lazysoundsystem |
| #7 | remove_t_from_openid_testsD7-1797370-7.patch | 29.52 KB | lazysoundsystem |
| #1 | openid-1797370-1.patch | 34.2 KB | xjm |
Comments
Comment #1
xjmComment #2
lazysoundsystem CreditAttribution: lazysoundsystem commentedI've reviewed all the changes and they all look good. RTBC.
Comment #3
Dries CreditAttribution: Dries commentedCommitted to 8.x.
Comment #4
jhodgdonThis needs backporting to D7. Also, can someone confirm everything was fixed in D8 and move this back there if not?
Comment #5
lazysoundsystem CreditAttribution: lazysoundsystem commentedI've checked and can confirm that all the t() functions for messages have been removed from this for 8.x
Comment #6
jhodgdonOK, we still need to backport to 7.x then. We only want to move back to 8.x if there is still something to be fixed there, and it sounds like there isn't (thanks for checking!).
Comment #7
lazysoundsystem CreditAttribution: lazysoundsystem commentedDidn't mean to change the version number, sorry about that. Anyway, here it is, for D7.
Comment #8
dcam CreditAttribution: dcam commentedOne assert message got missed on line 294 of openid.test. @lazysoundsystem if you can make that change then I'll re-test and we can get this committed.
Comment #9
lazysoundsystem CreditAttribution: lazysoundsystem commentedThanks @dcam, the overlooked t() from #8 is gone now.
Comment #10
dcam CreditAttribution: dcam commentedThanks @lazysoundsystem!
I applied #9 and didn't notice any additional t()'s for removal. The patch looks good to me.
Comment #11
jhodgdonThanks! This patch has been committed to 7.x.