Files: 
CommentFileSizeAuthor
#20 1797506-20-t-rdf.patch28.76 KBdcam
PASSED: [[SimpleTest]]: [MySQL] 40,336 pass(es).
[ View ]
#18 1797506_remove_t_assertTrue_18.patch28.67 KBsivaji
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1797506_remove_t_assertTrue_18.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#9 1797506-9-t-rdf.patch28.67 KBdcam
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1797506-9-t-rdf.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#4 1797506-4-t-rdf.patch30.8 KBLars Toomre
PASSED: [[SimpleTest]]: [MySQL] 41,900 pass(es).
[ View ]
#4 interdiff-1797506-1-4.txt703 bytesLars Toomre
#1 rdf-1797506-1.patch30.81 KBxjm
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/rdf/lib/Drupal/rdf/Tests/RdfaMarkupTest.php.
[ View ]

Comments

Assigned:xjm» Unassigned
Status:Active» Needs review
StatusFileSize
new30.81 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/rdf/lib/Drupal/rdf/Tests/RdfaMarkupTest.php.
[ View ]

In CommentAttributesTest (which belongs to rdf.module, but extends CommentTestBase), there is a use of setCommentSettings() with a translated message parameter. I left that out of this patch; it should be addressed in #1798066: Clean up CommentTestBase::setCommentSettings().

Status:Needs review» Needs work

The last submitted patch, rdf-1797506-1.patch, failed testing.

Oops.

Output: [PHP Parse error:  syntax error, unexpected ')' in ./core/modules/rdf/lib/Drupal/rdf/Tests/RdfaMarkupTest.php on line 167

I'll fix this later (or someone else is welcome to).

Status:Needs work» Needs review
StatusFileSize
new703 bytes
new30.8 KB
PASSED: [[SimpleTest]]: [MySQL] 41,900 pass(es).
[ View ]

All of the changes in #1 look good and complete to me. However, since this issue also needed to be fixed for an extra ')', I am leaving this issue to someone else to also review and approve.

Here is a patch and interdiff addressing #3.

Status:Needs review» Reviewed & tested by the community

#4 looks good. I didn't find any more t()'s around assert messages in the RDF module.

Thanks for the review @dcam. I rolled a new patch with additions you asked for in the Node sub-issue.

Assigned:Unassigned» jhodgdon

Tum te tum...

Version:8.x-dev» 7.x-dev
Assigned:jhodgdon» Unassigned
Status:Reviewed & tested by the community» Patch (to be ported)

This one's committed, thanks all! Ready for port...

Status:Patch (to be ported)» Needs review
StatusFileSize
new28.67 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1797506-9-t-rdf.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Backported #4 to D7.

#9: 1797506-9-t-rdf.patch queued for re-testing.

Issue tags:+Novice

Tagging as Novice.

Status:Needs review» Reviewed & tested by the community
Issue tags:+#SprintWeekend

this backport is good to go.

Thanks for the review, scor!

Status:Reviewed & tested by the community» Needs work

Status:Needs work» Needs review
Issue tags:-Novice, -needs backport to D7, -#SprintWeekend

#9: 1797506-9-t-rdf.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +needs backport to D7, +#SprintWeekend

The last submitted patch, 1797506-9-t-rdf.patch, failed testing.

Issue tags:+Needs reroll

Status:Needs work» Needs review
StatusFileSize
new28.67 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1797506_remove_t_assertTrue_18.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Patch #9 re-rolled.

Status:Needs review» Needs work

The last submitted patch, 1797506_remove_t_assertTrue_18.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new28.76 KB
PASSED: [[SimpleTest]]: [MySQL] 40,336 pass(es).
[ View ]

Rerolled #9.

Status:Needs review» Reviewed & tested by the community

thanks @dcam. this looks good.

Issue tags:-Needs reroll

removing reroll tag. we can add it back later if we need it.

Status:Reviewed & tested by the community» Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.