The secure way to make "links that do things" is to have the link include a token in the URL in a GET parameter, and then check that parameter as part of the access callback on the menu item.
Of course, that is something everyone has to do themselves, which means developers frequently forget to do so.
Whether or not a route needs an XSRF token on it should be centralized. In the new routing system, we can flag a route as needing such a token. Then we can always access check for it, and when generating URLs to that route we can always inject the token. That makes it a one-line task for developers.
This issue depends on:
Once we have a generator, this should be super easy to do:
1) Add an "xsrf" => TRUE option to a Route.
2) In the Generator, check and see if the route has an xsrf option set. If so, add a token=[token value goes here] GET parameter to it.
3) Add a new request listener (after the matcher listener) that checks if a route requires an XSRF token. If so, check if the incoming request has one and a valid one. If not, throw a 403 exception.
3) Add a new Access Checker that runs if the route has an xsrf tag, and if so check that the incoming request has a valid one. If not, return FALSE to let the access system throw a 403.
Get the above issues committed, then implement this. :-)
User interface changes
Adds a new option to Route object definitions.
|PASSED: [[SimpleTest]]: [MySQL] 59,540 pass(es).|
|PASSED: [[SimpleTest]]: [MySQL] 60,394 pass(es).|
|PASSED: [[SimpleTest]]: [MySQL] 60,121 pass(es).|