Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a sub-task of #500866: [META] remove t() from assert message focused on the Tracker module.
In D8 per http://drupal.org/simpletest-tutorial-drupal7#t, best practice is to remove t() from assert messages in tests. When necessary, t() should be replaced with format_string().
There are approximately 21 changes needed in a single test file. This issue includes conversion of all format_patch() occurances as well.
Comment | File | Size | Author |
---|---|---|---|
#5 | 1798366-5-tracker.patch | 6.7 KB | dcam |
#1 | 1798366-1-tracker.patch | 7.24 KB | Lars Toomre |
Comments
Comment #1
Lars Toomre CreditAttribution: Lars Toomre commentedHere is an initial untested patch for this issue. This patch includes format_string() conversions as well.
Comment #2
Lars Toomre CreditAttribution: Lars Toomre commentedHelps to set right status.
Comment #3
dcam CreditAttribution: dcam commentedEasy review. #1 looks good. I didn't find any additional t()'s around assert messages in the tracker module.
Comment #4
jhodgdonThanks! Committed to 8.x, ready for backport.
Comment #5
dcam CreditAttribution: dcam commentedBackported #1 to D7.
Comment #6
dcam CreditAttribution: dcam commented#5: 1798366-5-tracker.patch queued for re-testing.
Comment #7
dcam CreditAttribution: dcam commentedTagging as Novice.
Comment #8
cilefen CreditAttribution: cilefen commented#5 for D7 looks good to me. All t()'s are removed around assert messages.
Comment #9
jhodgdonThanks! I'll give this a final review and commit shortly.
Comment #10
jhodgdonThanks again! This is committed to 7.x.
There are only a few more of these issues left!!!
Comment #11.0
(not verified) CreditAttribution: commentedAdded count details.