Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a sub-task of #500866: [META] remove t() from assert message focused on the new Action module.
In D8 per http://drupal.org/simpletest-tutorial-drupal7#t, best practice is to remove t() from assert messages in tests. When necessary, t() should be replaced with format_string().
There are approximately 10 changes needed in two Test files. This issue includes conversion of all format_patch() occurances as well.
Comment | File | Size | Author |
---|---|---|---|
#1 | 1798954-1-t-action.patch | 5.03 KB | Lars Toomre |
Comments
Comment #1
Lars Toomre CreditAttribution: Lars Toomre commentedHere is an initial untested patch. It includes a format_string() change.
Comment #2
Lars Toomre CreditAttribution: Lars Toomre commentedHelps again to change the status!
Comment #3
Lars Toomre CreditAttribution: Lars Toomre commentedWhen this gets backported to D7, remember that these were broken out from an include file in the system module.
We also need a tag in the component list of this form for 'action.module'. I am unsure how that gets added.
Comment #4
andypostExactly all cleaned
Comment #5
Lars Toomre CreditAttribution: Lars Toomre commentedThanks @andypost!
Comment #6
webchickComment #7
jhodgdonCommitted to 8.x. As this is part of system.module tests for D7, I am not marking for backport.
Comment #8.0
(not verified) CreditAttribution: commentedAdded counts from initial patch.