I like the open in new tab (or browser) behavior.

The following patch implements that by drupal-variables. It's sub-optimal because they are global changeable in every block.

Micha

CommentFileSizeAuthor
twitter_block_link.patch4.92 KBmigmedia
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Active » Closed (works as designed)

Thanks for the patch but I believe that providing these options as per-block configuration settings is outside of the scope of the Twitter Block module.

You can already modify the twitter_block_preprocess_twitter_block_tweet() preprocess function to use whatever link function you desire and a themer could easily override $variables['text'] which could cause the admin options to have no effect.

Also target="_blank" is not valid XHTML 1.0 strict, which is what Twitter Block 7.x-1.x and 6.x-1.x must support (Twitter Block 8.x will be another matter!).

Ankabout’s picture

Ankabout CreditAttribution: Ankabout commented

Can anyone please show in this issue how I would go about making the links open in a new window? Either in a preprocess or another method?

Thanks!