Needs review
Project:
Password tab
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Oct 2012 at 08:48 UTC
Updated:
21 Sep 2015 at 11:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
chaloum commentedI'd most probably change line 80 in the password_policy_tab.module from
$path .= '/password';
to
$path=str_replace("/edit","/password",$path);
Comment #2
erikwebb commentedGive this a try.
Comment #3
mccraic commentedHello,
I replaced $path .= '/password'; with $path = str_replace("edit", "password", $path); and found a related issue which I needed to change as well to get the password reset to work properly. In password_policy_password_tab.pages.inc I needed to follow this https://drupal.org/node/1596960#comment-6691492 in order to remove the current password validation. Both of these changes are necessary in order to redirect the one time login to the correct page and remove current password validation for a forgotten password.
Thanks for the help,
Patrick
Comment #4
erikwebb commented@mccraic - I believe we have a cleaner solution to your problem. Could you try this one?
https://drupal.org/node/1596960#comment-6831368
Comment #5
erikwebb commentedCombining the separate suggestions together. Can I get a test on this patch?
Comment #6
juanramonperez commented#5 works for me, I only changed the line
Instead of
Comment #7
erikwebb commented@juanramonperez - I was hoping to avoid issues if there is an "edit" string somewhere else in the URL. Did the patch as is resolve the problem for you?
Comment #8
juanramonperez commented@erikwebb the patch in #5 didn't work for me, there are some problem with the redirect path
Comment #9
erikwebb commentedComment #10
erikwebb commentedComment #11
erikwebb commentedhttp://drupalcode.org/project/password_policy.git/commit/9208361
Now let's get this into Password Tab.
Comment #12
erikwebb commentedComment #13
erikwebb commentedhttp://drupalcode.org/project/password_tab.git/commit/23ac750
Comment #15
pedrospThe last dev version (#13 patch already there) did'nt work for me.
But after struggling a little bit, I found a solution with a new module that improve the password landing reset page http://drupal.org/project/prlp .
I think both maintainers should evaluate joining forces.
Comment #16
erikwebb commented@pedrosp - What's the specific problems that you're still having?
Comment #17
pedrosp@erikwebb the reset password request link didn't redirect to the password tab.
Maybe some order module or rule is having something to do with that, however as I pointed in #15, I can move on.
Maybe this is related also my other issue http://drupal.org/node/1843350 (impossible to update use email , ask for password)
Comment #18
pvasener commentedI still have a issue using the link in the Reset link in the e-mail, I am led to:
http://www.xxx.xxx/user/13/edituser/13/password?pass-reset-token=39nALa7...
instead of
http://www.xxx.xxx/user/13/password?pass-reset-token=39nALa7zkwKiUCj6DFq...
This small patch fixed that.
Comment #20
khaldoon_masud commentedthis patch has a small error:
$path .= preg_replace('/\/edit$/', '/\/password/', $path);
should be
$path = preg_replace('/\/edit$/', '/\/password/', $path);
Comment #21
khaldoon_masud commented#18: password_tab-1802978.patch queued for re-testing.
Comment #23
techgirlgeek commentedHere's a patch that incorporates the fix in #20 [#7911179].
When performing the replacement on the $path variable, it should be set to replace, not append, to the current path.
Comment #24
tancPatch in #23 works for me. The url is just a straight replacement and should not be appended.
Comment #25
erikwebb commentedhttp://drupalcode.org/project/password_tab.git/commit/daa0301
Comment #27
OlyN commentedThe solution previously applied to this issue is incompatible with i18n and language-prefixed paths, or any other modules that alter the relevant paths. I've created a patch which resolves this by invoking hook_url_inbound_alter() instead of hook_exit().
Comment #28
OlyN commentedComment #29
adevms commentedI had the problem of not redirecting to the correct url which then let's me enter my password after the one time login. After applying the patch in #27 everything is working as it should be.