Double Payments Shown (Charged Once) and No Email Notifications

Honestly, I'm not sure how this can happen. Part of our IPN validation prior to actually creating any payment transaction is to ensure the IPN hasn't already been processed. The pertinent code is in commerce_paypal.module:

  // Exit if the IPN has already been processed.
  if (!empty($ipn['txn_id']) && $prior_ipn = commerce_paypal_ipn_load($ipn['txn_id'])) {
    if ($prior_ipn['payment_status'] == $ipn['payment_status']) {
      watchdog('commerce_paypal', 'Attempted to process an IPN that has already been processed with transaction ID @txn_id.', array('@txn_id' => $ipn['txn_id']), WATCHDOG_NOTICE);
      return FALSE;
    }
  }

Do you see that message in your log anywhere? Looking at the timestamps in your payment transaction data arrays, I can see that these transactions are being create a mere 15 seconds apart. The challenge will be to determine why - what can result in this happening without the above check not catching the problem?

Do you have any custom code running on this site at all? Anything else you can glean from the logs? Why not turn on IPN logging and look at how the IPN array is structured. Does it actually have a txn_id specified each time?

Also getting double entries. System loggin says this. It validates the order twice:

__________
commerce_paypal_wps 05.02.2013 - 21:21 IPN processed for Order 4353 with ID (.......). Guest (not confirmed)

commerce_paypal_wps 05.02.2013 - 21:21 IPN validated for Order 4353 with ID (.....). Guest (not confirmed)

Rules 05.02.2013 - 21:21 Unable to evaluate condition entity_has_field. Guest (not confirmed) edit configuration

Rules 05.02.2013 - 21:21 The variable or parameter entity is empty. Guest (not confirmed)

variable_email 05.02.2013 - 21:21 Successfully sent email to office@.......com Guest (not confirmed)

Rules 05.02.2013 - 21:21 Successfully sent email to office@......com Guest (not confirmed)

commerce_paypal_wps 05.02.2013 - 21:21 IPN validated for Order 4353 with ID (.....).
__________

The IPN message is not being saved, because there is a redirect before.
Since IPN message in not saved, whem the next message comes in (Paypal tries a few times if it it thinks it failed), there is not way to see if it's a dublicate.

The attached patch is for WPS. Maybe the same problem persists on other method.

@Ryan, I'm hoping you may be able to chime again with some more info. We're experiencing the exact same issue as the original poster.

A small percentage of checkouts using Paypal WPS produce the following issues:

1. Double entries in the order payment tab -- although the actual Paypal charge only goes through once (see screenshot).
2. commerce_checkout_complete() does not appear to be called and, therefore, the Rules dependent on "Completing the checkout process" never fire, resulting in no emails be sent, or the order status being changed properly.
3. The order Revisions tab also shows the last entry as being from Anonymous instead of the customer and the status being Checkout: Complete(see screenshot). While orders without this issue show this entry as being from the customer account and then other Rules fire from the commerce_checkout_complete() function.

There are watchdog errors right after the commerce_paypal_wps IPN validated... log entry:

Location: SITE_URL/commerce_paypal/ipn/paypal_wps%7Ccommerce_payment_paypal_wps

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '' for key 'name': INSERT INTO {users} (uid, name, pass, mail, theme, signature, signature_format, created, access, login, status, timezone, language, picture, init, data) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7, :db_insert_placeholder_8, :db_insert_placeholder_9, :db_insert_placeholder_10, :db_insert_placeholder_11, :db_insert_placeholder_12, :db_insert_placeholder_13, :db_insert_placeholder_14, :db_insert_placeholder_15); Array ( [:db_insert_placeholder_0] => 25044 [:db_insert_placeholder_1] => [:db_insert_placeholder_2] => [:db_insert_placeholder_3] => [:db_insert_placeholder_4] => [:db_insert_placeholder_5] => [:db_insert_placeholder_6] => [:db_insert_placeholder_7] => 0 [:db_insert_placeholder_8] => 0 [:db_insert_placeholder_9] => 0 [:db_insert_placeholder_10] => 0 [:db_insert_placeholder_11] => [:db_insert_placeholder_12] => [:db_insert_placeholder_13] => 0 [:db_insert_placeholder_14] => [:db_insert_placeholder_15] => a:1:{s:17:"mimemail_textonly";i:0;} ) in drupal_write_record() (line 7387 of /home/SITE/public_html/includes/common.inc).

This only happens to a small percantage of the orders but when it does it causes major issues, mainly because commerce_checkout_complete() is never called.

Any ideas on what may cause this? Or, is it possible to at least put in a safegaurd to make sure commerce_checkout_complete() is called?

I wonder if this could also be tied to https://www.drupal.org/project/commerce_paypal/issues/2842938 since we're not loading previous IPNs via their txn_id

The patch in #4 will not solve the issue. The IPN is only "skipped" if it is missing a txn_id or has an invalid state.

If there is no txn_id, no steps are taken:

  // Do not perform any processing on WPS transactions here that do not have
  // transaction IDs, indicating they are non-payment IPNs such as those used
  // for subscription signup requests.
  if (empty($ipn['txn_id'])) {
    return FALSE;
  }

If it's an invalid step the order is kicked back a step

  // Exit when we don't get a payment status we recognize.
  if (!in_array($ipn['payment_status'], array('Failed', 'Voided', 'Pending', 'Completed', 'Refunded'))) {
    commerce_payment_redirect_pane_previous_page($order);
    return FALSE;
  }

RE: #5.

The order Revisions tab also shows the last entry as being from Anonymous instead of the customer and the status being Checkout: Complete(see screenshot).

That is because the IPN did its job and pushed the order through checkout. It calls commerce_payment_redirect_pane_next_page($order); at the end of its processing.

The following should have, then, been called:

    // Inform modules of checkout completion if the next page is Completed.
    if ($next_page == 'complete') {
      commerce_checkout_complete($order);
    }

Also, #5: your error is something trying to create a new user. That is not a bug from this module.

Closing this as duplicate of #2036149: PayPal WPS not updating completing checkout to join forces, because I guess all these issues (see #2036149-33) are based on the same problem.

I think it's a race condition between IPN and UI!

If you guess I'm wrong and this issue is not a duplicate, please feel free to reopen. Otherwise please help to finally fix that issue! :)