I noticed today that on my site, Global Redirect does not appear to be working at all. Pages that are located at URLs like "/node/186" are not being redirected to their pathauto equivalents. So for an example, if you navigate to http://www.gigindie.com/node/186 you should be redirected to http://www.gigindie.com/venue/cafe-coda-chico. Similarly, http://www.gigindie.com/taxonomy/term/26/ does not redirect to http://www.gigindie.com/blog/tag/albums and http://www.gigindie.com/user/421/ does not go to http://www.gigindie.com/users/janafisher. Additionally, trailing slashes are not being removed, etc.
I haven't tagged this as a major issue since I'm not sure if others are experiencing it. Any suggestions? Could it be a conflict with something else?
Comment | File | Size | Author |
---|---|---|---|
#7 | globalredirect-drupal_alter_removal_redirection_fix-1805616-7.patch | 726 bytes | ben.denham |
Comments
Comment #1
mrweiner CreditAttribution: mrweiner commentedWhen I first wrote my post I thought that only pathauto URLs weren't working, so that was the title. Just realized I forgot to change it after adding some more info about the issue.
Comment #2
mrweiner CreditAttribution: mrweiner commentedI was hoping that just posting the issue would get it some attention, but since the module is still completely broken on my site, I'm changing the status to major. Any input on the matter would be greatly appreciated.
Comment #3
kemitix CreditAttribution: kemitix commentedI'm having the same issue. Could your problem be caused by this issue http://drupal.org/node/304025
Comment #4
mrweiner CreditAttribution: mrweiner commentedNope, doesn't look that way. It's not installed in a subdirectory, and I'm not on D6 either.
Comment #5
TelFiRE CreditAttribution: TelFiRE commentedYep, mine is completely non-functional too and a quick look around shows a whole lot of people having the same problem :/
Comment #6
mrweiner CreditAttribution: mrweiner commentedFor anybody who comes across this, take a look at #905914: Merge global redirect functions into Redirect module. Although it does not solve the problem for Global Redirect, they are working on implementing its features into the Redirect module. The most recent patch in there appears to provide most of the functionality performed by Global Redirect. It's a work in progress, so obviously its not finished or the best it could be, but it is certainly on its way.
It's also better than nothing, which is what I have at the moment with Global Redirect. ;)
Comment #7
ben.denham CreditAttribution: ben.denham commentedI have been experiencing the same issue.
It appears that after the call to drupal_alter on line 80 of globalredirect.module, $request_path (which should be the entered path, i.e. node/123) is being set to the new, correct alias.
The test on line 217 then checks that $request_path is not equal to the retrieved alias, otherwise it deems the redirect unnecessary.
It appears to me that path_alias_xt_url_outbound_alter() in the Extended Path Alias module is changing the $request_path into the alias.
I have attached a quick patch that removes the call to drupal_alter, thereby eliminating the apparent conflict with the Extended Path Alias module (and perhaps other modules).
However, I'm not sure of what effect this may cause (especially to sites with different languages, based on the comments next to the drupal_alter), but it appears to restore basic redirection functionality.
Comment #8
phiscock CreditAttribution: phiscock commentedThank you. I was having this problem even with Extended Path Alias uninstalled. The patch seems to have solved my problems.
Comment #9
fox_01 CreditAttribution: fox_01 commentedPatch worked for me, too.
Comment #10
jesss CreditAttribution: jesss commentedThe patch in #7 didn't work for me. node/xxx still isn't redirecting to pretty-alias.
Comment #11
nicholasThompsonRemarking out drupal_alter isn't really a solution - but it's interesting it is causing a problem.
I'll try to take a look ASAP.
Comment #12
MO-2 CreditAttribution: MO-2 commentedPatch in #7 worked for me.
Comment #13
plusproduit CreditAttribution: plusproduit commented#48 seems to work but fires a notice with language path
Comment #14
RavindraSingh CreditAttribution: RavindraSingh commentedCan someone explain steps to reproduce? I am also trying to replicate in 7.x-1.5 as describe in issue summary but not able to reproduce.
Comment #15
Marc DeLay CreditAttribution: Marc DeLay as a volunteer commented@mrweiner is this still an issue for you?
Going to the example urls in your report redirect me to the alias urls so it seems like this issue is resolved.
Please reopen if this is not correct.