Files: 
CommentFileSizeAuthor
#13 1807266-cmi_user-cancel-method-13.patch10.8 KBcam8001
PASSED: [[SimpleTest]]: [MySQL] 46,348 pass(es).
[ View ]
#13 interdiff.txt1.61 KBcam8001
#10 1807266-cmi_user-cancel-method-9.patch11.05 KBcam8001
PASSED: [[SimpleTest]]: [MySQL] 46,404 pass(es).
[ View ]
#10 interdiff.txt3.01 KBcam8001
#8 1807266-cmi_user-cancel-method-8.patch8.64 KBcam8001
PASSED: [[SimpleTest]]: [MySQL] 46,247 pass(es).
[ View ]
#3 1807266-user-cancel-method-3.patch9.21 KBbarbun
PASSED: [[SimpleTest]]: [MySQL] 42,078 pass(es).
[ View ]
#1 1807266-user-cancel-method-2.patch8.5 KBbarbun
FAILED: [[SimpleTest]]: [MySQL] 42,047 pass(es), 18 fail(s), and 0 exception(s).
[ View ]

Comments

StatusFileSize
new8.5 KB
FAILED: [[SimpleTest]]: [MySQL] 42,047 pass(es), 18 fail(s), and 0 exception(s).
[ View ]

And here's the patch.

Status:Needs review» Needs work

The last submitted patch, 1807266-user-cancel-method-2.patch, failed testing.

Status:Needs review» Needs work
StatusFileSize
new9.21 KB
PASSED: [[SimpleTest]]: [MySQL] 42,078 pass(es).
[ View ]

Ok, added small tweak for default value.

Btw, I built my patch over this:
http://git.drupal.org/sandbox/heyrocker/1145636.git

is that ok?

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 1807266-user-cancel-method-3.patch, failed testing.

Status:Needs work» Needs review

#3: 1807266-user-cancel-method-3.patch queued for re-testing.

This patch looks basically fine, just a few whitespace issues:

+++ b/core/modules/statistics/lib/Drupal/statistics/Tests/StatisticsAdminTest.phpundefined
@@ -137,8 +137,8 @@ class StatisticsAdminTest extends WebTestBase {
-    variable_set('user_cancel_method', 'user_cancel_delete');
+    ¶

There's a few leading whitespace issues like this.

+++ b/core/modules/user/user.admin.incundefined
@@ -654,6 +655,7 @@ function user_admin_settings_submit($form, &$form_state) {
     ->set('signatures', $form_state['values']['user_signatures'])
+    ->set('cancel_method', $form_state['values']['user_cancel_method'])      ¶

Trailing whitespace here.

I will post a patch shortly...

Status:Needs work» Needs review
StatusFileSize
new8.64 KB
PASSED: [[SimpleTest]]: [MySQL] 46,247 pass(es).
[ View ]

Cleaned up the whitespace stuff.

It probably wouldn't hurt to add some basic test coverage for this, see SystemUpgradePathTest.php (we should rename that to ConfigUpgradePathTest in another issue). Then we don't have to test it manually to RTBC this.

StatusFileSize
new3.01 KB
new11.05 KB
PASSED: [[SimpleTest]]: [MySQL] 46,404 pass(es).
[ View ]

Ok so I have added an upgrade path, and set the default for the value in user.settings.yml instead of using a ternary.

There's an unused variable, $default_method, in user_cancel_confirm_form(), which is in D7 as well, so I wil create an issue for that once this gets committed.

Not sure if we need a separate test method for this, because it's the same database dump anyway. Other than that, this looks good to me.

StatusFileSize
new1.61 KB
new10.8 KB
PASSED: [[SimpleTest]]: [MySQL] 46,348 pass(es).
[ View ]

Moved tests into same method, renamed, and updated comment.

Status:Needs review» Reviewed & tested by the community

Yes, I think this is fine like this.

Status:Reviewed & tested by the community» Fixed

Looks good. Committed/pushed to 8.x.

Great stuff. I have posted a patch over in #1825648: Rename SystemUpgradePathTest to ConfigUpgradePathTest, so we can have tests for the CMI upgrade path, if we can get that or something similar in it will be a good conduit to increasing test coverage of the conversion effort.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Updated issue summary.