This triggers all node update functions when a new comment is added for that node. Because we only store per-View setting, we cannot easily check this when hook_comment_*() is called. We can probably setup a global setting to toggle this behavior, but I'm not sure a logical place to put this solitary setting.

CommentFileSizeAuthor
#4 views_content_cache-trigger_node_updates_comment-1807994-4.patch2.17 KBerikwebb
#1 views_content_cache-trigger_node_updates_comment-1807994-1.patch1.75 KBerikwebb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

erikwebb’s picture

erikwebb CreditAttribution: erikwebb commented
Status: Active » Needs review
FileSize
views_content_cache-trigger_node_updates_comment-1807994-1.patch1.75 KB

Status: Needs review » Needs work

The last submitted patch, views_content_cache-trigger_node_updates_comment-1807994-1.patch, failed testing.

erikwebb’s picture

erikwebb CreditAttribution: erikwebb commented

If this is a direction that we want to go, I'll update the tests accordingly.

erikwebb’s picture

erikwebb CreditAttribution: erikwebb commented
FileSize
views_content_cache-trigger_node_updates_comment-1807994-4.patch2.17 KB

I've wrapped this behavior inside of a off-by-default variable until we figure out a decent place to put this.

erikwebb’s picture

erikwebb CreditAttribution: erikwebb commented
Status: Needs work » Needs review
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Issue summary: View changes
Parent issue: » #1785418: Plan for Views Content Cache 7.x-3.0 release