This is a sub-issue of #1800046: [META] Add missing type hinting to core docblocks focused on correctly adding @param and @return type hinting to the Comment module.

Documentation patches that include type hinting are time consuming to both review and commit because one must dig into the actual code to confirm that the type hints are both correct and complete. Hence, please be patient and try to limit type hint patches to covering only a limited number of docblocks (10-15 as a guess).

Related sprint issues:

Sprint Topic Sub Issue
#1518116: [meta] Make Core pass Coder Review #1532692: Make Comment module pass Coder Review
#1310084: [meta] API documentation cleanup sprint #1332598: Clean up API docs for comment module
#500866: [META] remove t() from assert message #1742602: Removing t() from asserts in simpletests in comment module
#1 1808478-1-comment-api.patch1.91 KBLars Toomre
PASSED: [[SimpleTest]]: [MySQL] 42,116 pass(es).
[ View ]


new1.91 KB
PASSED: [[SimpleTest]]: [MySQL] 42,116 pass(es).
[ View ]

Here is a patch that adds type hinting to the hooks in comment.api.php file.

Status:Active» Needs review

Lars, can this be held off till after feature freeze?
I don't want to have to reroll #731724: Convert comment settings into a field to make them work with CMI and non-node entities

@larowlan I do want to have you re-roll #731724: Convert comment settings into a field to make them work with CMI and non-node entities.

As you might notice, the initial patch in #1 in quite small. Perhaps you might just include those changes in your work before you next roll a patch from your sandbox? They are simply type hinting additions to comment.api.php file.

I will hold off on further patches about type hinting in the Comment module until after feature freeze.

Thanks, will do.

Status:Needs review» Postponed

Postponed until after feature freeze (Dec. 1 2012) for #3.