It is follow-up from #1300920-72: The [node:summary] token does not output anything for body fields without a manual summary

Text widget already converted into plugin so it's a Novice task

Files: 
CommentFileSizeAuthor
#4 added_elemente_validate_integer_positive__for__trim_lenght-1808942-4.patch779 bytesnick_schuch
PASSED: [[SimpleTest]]: [MySQL] 42,815 pass(es).
[ View ]
#2 added_elemente_validate_integer_positive__for__trim_lenght-1808942-2.patch582 bytesBrolag
PASSED: [[SimpleTest]]: [MySQL] 42,188 pass(es).
[ View ]

Comments

Issue tags:+needs backport to D7

Won't it need a backport to D7?

Status:Active» Needs review
StatusFileSize
new582 bytes
PASSED: [[SimpleTest]]: [MySQL] 42,188 pass(es).
[ View ]

Could someone please review my patch? Thanks! :)

NOTE: Patch made at Drupal Camp Central America 2012.

Status:Needs review» Needs work

@Brolag great! now we need a test to make sure that it works properly
Suppose this code should be modified to assert a wrong (none-numberic) value

Status:Needs work» Needs review
StatusFileSize
new779 bytes
PASSED: [[SimpleTest]]: [MySQL] 42,815 pass(es).
[ View ]

Tried to kick off some tests but looks like core has moved on since this last patch. So here is the new one :)

Great! Is it possible to create 2 patches: one with only modified test (this patch is supposed to fail, and that's ok), and the second one, which contains validation and test modification?

Status:Needs review» Needs work

sorry, forgot to change status

Assigned:Unassigned» nick_schuch

Working on tests.

Status:Needs work» Closed (duplicate)

After writing tests and pulling down the lastest 8.x I discovered that element_validate_positive_integer has been taken away in place of a number field with '#min' set to 1.