Am I the only one who is majorly annoyed with this horrible autosubmit function of views? It constantly submits after the first letter and after that the input field is no longer active and needs to be clicked again to type further. First thing I change in the provided views.

CommentFileSizeAuthor
#7 fontyourface-Disable_autosubmit_for_font_browsing-1810308-7.patch3.42 KBDrave Robber
#4 fontyourface-Disable_autosubmit_and_AJAX_in_browsing_defaults-1810308-4.patch3.75 KBDrave Robber
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sreynen’s picture

sreynen CreditAttribution: sreynen commented

I'm fine with disabling the auto-refresh. Do you want to post a patch? I think you should be able to just re-export the altered view.

dddave’s picture

dddave CreditAttribution: dddave commented

I sure would do that if I could. I neither have a suitable set-up at the moment nor have I ever created a patch before I have to admit ashamed. Sorry.

Drave Robber’s picture

Drave Robber CreditAttribution: Drave Robber commented

I second third this, and would also suggest turning AJAX off in default settings. Defaults need to be conservative enough to work out of box for at least 95% (preferably 99%). (I have a vague suspicion that AJAX is behind short preview working only on the first page for me.)

Drave Robber’s picture

Drave Robber CreditAttribution: Drave Robber commented
Status: Active » Needs review
FileSize
fontyourface-Disable_autosubmit_and_AJAX_in_browsing_defaults-1810308-4.patch3.75 KB

Here's a patch to that effect.

dddave’s picture

dddave CreditAttribution: dddave commented
Version: 7.x-2.5 » 7.x-2.x-dev
Status: Needs review » Reviewed & tested by the community

Thank you. Works as advertised.

sreynen’s picture

sreynen CreditAttribution: sreynen commented
Title: Please disable autosubmit for font browsing » Please disable autosubmit for font browsing (and also maybe turn off AJAX)
Status: Reviewed & tested by the community » Needs work

I think this could use some work:

  1. Without auto-submit, we have an "Apply" button, which pushes the "Reset" button down to its own line on the Google tab (with the subset filter) for me. This could maybe be fixed with some CSS to make the filters less wide. This is obviously relative to window size, but I think 5 fonts wide is a reasonable max for the form width.
  2. I think this may need an update hook. When I first applied the patch, my Views all stopped working. They were trying to make AJAX calls still, but the AJAX wasn't responding. Clearing my cache seemed to fix this, making AJAX work again, but I had to revert the views to see the actual updates. The first part might be specific to my dev environment, but the views revert is, I think, necessary for all existing installs to get the new interface.
  3. I'm not very excited about turning off AJAX. I know AJAX introduces a lot of complications, but I think it's worth working through those complications for a better interface.
Drave Robber’s picture

Drave Robber CreditAttribution: Drave Robber commented
Status: Needs work » Needs review
FileSize
fontyourface-Disable_autosubmit_for_font_browsing-1810308-7.patch3.42 KB

1. Let me guess - 1280px wide without overlay? The bad news is it looks even uglier in overlay (for all providers, not only Google); the good news is it's indeed easily fixed with some CSS. (I normally use 1600x1200 and hadn't noticed all this; not sure what is the lowest resolution worth bothering about nowadays.)

Patch attached.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Issue summary: View changes
Status: Needs review » Closed (outdated)