" I tmight make sense to present the actual output of the .rej files that patch produces in such cases."

Sounds like a good idea to me :)

Robin

Comments

boombatower’s picture

boombatower CreditAttribution: boombatower commented

talked to webchick about idea...

She came up with store "rejected hunks" (heh) in a field and displaying on the testing results page.

This can be done, it has to be aggregated from testing slaves...so a bit of coding involved. This is really low on my priority list, but any else is welcome to make patch against PIFR (project_issue_file_review).

jthorson’s picture

jthorson CreditAttribution: jthorson commented
Project: Test driven development infrastructure » Drupal.org Testbots

Moving over from abandoned testing infra queue

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
Project: Drupal.org Testbots » DrupalCI: Test Runner
Issue summary: View changes

Perhaps this will be part of the error output on drupalci patch application. Almost 9 years later.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
Component: Code » Artifacts and Output
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
Component: Artifacts and Output » Codebase Build
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
Component: Codebase Build » Artifacts and Output
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
Status: Active » Fixed

When patches fail to apply, the output is captured and displayed on subsequent pages. Rejected hunks are really not worth it to return.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.