Files: 
CommentFileSizeAuthor
#12 user_password_reset_timeout-1814558-12.patch3.24 KBLinL
PASSED: [[SimpleTest]]: [MySQL] 46,445 pass(es).
[ View ]
#9 user_password_reset_timeout-1814558-9.patch3.24 KBLinL
PASSED: [[SimpleTest]]: [MySQL] 46,363 pass(es).
[ View ]
#4 user_password_reset_timeout-1814558-4.patch3.24 KBLinL
PASSED: [[SimpleTest]]: [MySQL] 46,243 pass(es).
[ View ]
#3 user_password_reset_timeout-1814558-3.patch3.11 KBLinL
PASSED: [[SimpleTest]]: [MySQL] 42,819 pass(es).
[ View ]
#1 user_password_reset_timeout-1814558-1.patch3.12 KBLinL
FAILED: [[SimpleTest]]: [MySQL] 42,402 pass(es), 3 fail(s), and 2,618 exception(s).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new3.12 KB
FAILED: [[SimpleTest]]: [MySQL] 42,402 pass(es), 3 fail(s), and 2,618 exception(s).
[ View ]

First stab at converting to config - here's a patch.

Status:Needs review» Needs work

The last submitted patch, user_password_reset_timeout-1814558-1.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new3.11 KB
PASSED: [[SimpleTest]]: [MySQL] 42,819 pass(es).
[ View ]

StatusFileSize
new3.24 KB
PASSED: [[SimpleTest]]: [MySQL] 46,243 pass(es).
[ View ]

Included in user.settings.yml instead of a separate yml.

Do we want to extend the existing generic user.settings update function to include this instead of adding another one?

8.x -> 8.x updates aren't supported and this is just an internal setting without UI that nobody has set to something else (in 8.x at least ;)) anyway.

Would avoid adding another one that could possibly conflict with other issues.

Status:Needs review» Reviewed & tested by the community

I don't know, update settings conflicts are par for the course, and I can't remember a time when we've added stuff into existing update functions like that before? I'd rather just get this in and move on. I looked it over and otherwise it looks good, so lets go!

@heyrocker #1807266: Convert user_cancel_method variable to CMI system does exactly that, that's why I suggested it.

Anyway, getting this in like this is fine with me as well.

Status:Reviewed & tested by the community» Needs work

Actually, I agree it'd be nice to group like-updates together in the same update function. Can we get a quick re-roll for that? Feel free to mark back to RTBC after; as long as testbot says it's good, I can commit it.

Assigned:LinL» Unassigned
Status:Needs work» Needs review
StatusFileSize
new3.24 KB
PASSED: [[SimpleTest]]: [MySQL] 46,363 pass(es).
[ View ]

Re-rolled to remove extra update function.

Status:Needs review» Reviewed & tested by the community

Thanks, back to RTBC then, as webchick requested.

Status:Reviewed & tested by the community» Needs work

Looks like this needs a quick re-roll.

Status:Needs work» Needs review
StatusFileSize
new3.24 KB
PASSED: [[SimpleTest]]: [MySQL] 46,445 pass(es).
[ View ]

Status:Needs review» Reviewed & tested by the community

And back to RTBC again.

Status:Reviewed & tested by the community» Needs work
Issue tags:-Configuration system

The last submitted patch, user_password_reset_timeout-1814558-12.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Configuration system

Status:Needs review» Reviewed & tested by the community

Back to RTBC.

Status:Reviewed & tested by the community» Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.