Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In UpgradePathTestBase::performUpgrade(), there is the following comment:
// @todo Remove the try/catch when UpgradePathTestBase::setup() is fixed to
// boot DrupalKernel (as WebTestBase::setup() does).
#1786990: [Module]Bundle is registered too late in WebTestBase::setUp() added TestBase::rebuildContainer(), which I think it needed here.
I think the comment is technically wrong, since the relevant parts of WebTestBase::setUp() are left to UpgradePathTestBase::performUpgrade().
This blocks any issue trying to use bundles during upgrade tests, hence it being major.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | drupal-1816726-1.patch | 1.04 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettWebTestBase::setUp() sets up and completely installs Drupal.
UpgradePathTestBase::setUp() just gets the environment ready, and leaves the installing to UpgradePathTestBase::performUpgrade(), which is why the fix is in there.
Comment #2
tim.plunkettTagging, since we need this for Views
Comment #3
tim.plunkettThe removed calls to drupal_flush_all_caches(), WebTestBase::refreshVariables(), WebTestBase::checkPermissions() are all contained in WebTestBase::resetAll()
Comment #4
effulgentsia CreditAttribution: effulgentsia commentedLooks fine to me and it's green. Nice to see that rebuilding the container makes the try/catch unnecessary.
Comment #5
webchickI think I somehow committed this with something else. Woohoo?