Pager has "Display a specified number of items | 0 items", instead shows all

I agree that this can confuse people, even it should be actually better to use the none pager instead.

This is limited to when the pager is manually set to "Display a specified number of items" and the value is set at "0". When creating a new view, if one types "0" in the "Items to display" option, Views will automatically set the appropriate pager setting to "Display all items" which shows a less confusing "Display all items | all items" message.

I would agree that it's confusing, and in the case the user does manually set the pager to "specified number" it might be better to have Views automatically switch the pager type back to "Display all items" for convenience if the "number of items" has been set to "0".

In the meantime, I've rolled a patch which will simple change the displayed language to be less confusing as proposed by the author. "Display a specified number of items" will now show "All items" if the value is set to 0 versus "0 items"

My solution was just to check $this->options['items_per_page'] for a "0" value and return the appropriate language.

Here's the code change within the class views_plugin_pager_some extends views_plugin_pager inside views_plugin_pager_some.inc:

    if ($this->options['items_per_page'] == 0) {
      return t('All items');
    }

Tested on a live installation and everything seems to work as expected.

#2: pagerallitems-1817442-2.patch queued for re-testing.

If you want to make this change, you should make it for all relevant pagers (full, mini, some).

The patch should also handle pagers with offsets properly - emitting 'All items, skip @skip'

Actually, since all four pagers use the same logic, it may be cleaner to add a utility method, then call it from each. However, in order to preserve full translate-ability that would mean dynamically constructing the string to be translated, which is probably bad for discoverability.

Here's a patch that provides "All Items" messages on full/mini/some pagers. The changes for each look like (ignoring whitespace):

   function summary_title() {
     if (!empty($this->options['offset'])) {
+      if (!empty($this->options['items_per_page'])) {
         return format_plural($this->options['items_per_page'], '@count item, skip @skip', '@count items, skip @skip', array('@count' => $this->options['items_per_page'], '@ski
       }
+      return t('All items, skip @skip', array('@skip' => $this->options['offset']));
+    }
+    if (!empty($this->options['items_per_page'])) {
       return format_plural($this->options['items_per_page'], '@count item', '@count items', array('@count' => $this->options['items_per_page']));
     }
+    return t('All items');
+  }

Applied to HEAD and works as described!

Re-rolled the patch with the current path of the Views plugins.

The views path is now: views/plugins/...

@chris-matthews re-rolled the patch, based on your comment.

@elaman the patch looks good. The patch applied to the module successfully. Please find the attached screenshot for the same.