Problem/Motivation

The mimemail module causes errors in the flag module because it fails to specify triggers in mimemail_rules_action_info. According to the documentation for hook_action_info, the 'triggers' key is required. See this comment from the author of the flag module saying that he does not consider this to be a bug in that module.

Proposed resolution

Add 'triggers' => array('any') to mimemail_rules_action_info.

Remaining tasks

Will attach my patch but needs testing.

CommentFileSizeAuthor
#1 mimemail-action-triggers-1817898-1.patch698 bytessamalone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

samalone’s picture

samalone CreditAttribution: samalone commented
Status: Active » Needs review
FileSize
mimemail-action-triggers-1817898-1.patch698 bytes

My proposed patch is attached.

sgabe’s picture

sgabe CreditAttribution: sgabe commented
Project: Mime Mail » Pathauto
Status: Needs review » Closed (duplicate)

The hook_action_info() implementation in Mime Mail is right, see in the repository. I think this was triggered and fixed by Pathauto in #1356786: Notice: Undefined index: triggers in flag_node->get_valid_actions() (line 1334 of /hsphere/local/home/...../sites/all/modules/fl.