Problem/Motivation

The views_bulk_operations module causes errors in the flag module because it fails to specify triggers in the actions returned by views_bulk_operations_rules_action_info. According to the documentation for hook_action_info, the 'triggers' key is required. See this comment from the author of the flag module saying that he does not consider this to be a bug in that module.

Proposed resolution

Add 'triggers' => array('any') to the info functions in each of the files in the actions subdirectory.

Remaining tasks

Will attach my patch but needs review.

CommentFileSizeAuthor
#5 views_bulk_operations-add_triggers_in_actions-1817978-5.patch825 bytesofry
#1 views_bulk_operations-action-triggers-1817978-1.patch2.53 KBsamalone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

samalone’s picture

samalone CreditAttribution: samalone commented
Status: Active » Needs review
FileSize
views_bulk_operations-action-triggers-1817978-1.patch2.53 KB

My proposed patch is attached.

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ofry’s picture

ofry CreditAttribution: ofry commented
Issue summary: View changes
Status: Closed (fixed) » Active

Again same bug in actions views_bulk_operations_delete_revision and views_bulk_operations_user_cancel_action.

ofry’s picture

ofry CreditAttribution: ofry commented
FileSize
views_bulk_operations-add_triggers_in_actions-1817978-5.patch825 bytes

There is my patch.

ofry’s picture

ofry CreditAttribution: ofry commented
ofry’s picture

ofry CreditAttribution: ofry commented
Status: Active » Needs review
bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Needs review » Fixed

Added the missing line to book actions as well, and committed.

  • bojanz committed 86f99ed on 7.x-3.x authored by ofry 
    Issue #1817978 by ofry, samalone: Fixed Undefined index: triggers in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.