Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a follow-up issue spun off from #1818016: Make Breakpoint module pass Coder Review.
Its purpose is to address and correct in core those items discovered in a manual review of the Breakpoint module that were not caught by the current Coder review report.
Follow-up issues
Comment | File | Size | Author |
---|---|---|---|
#5 | 1820512-5-breakpoint.patch | 10.42 KB | Lars Toomre |
#1 | 1820512-1-breakpoint.patch | 10.62 KB | Lars Toomre |
Comments
Comment #1
Lars Toomre CreditAttribution: Lars Toomre commentedThe attached patch addresses all of the items in #1818016-7: Make Breakpoint module pass Coder Review that were not subsequently covered in the patch for that issue.
Comment #2
Lars Toomre CreditAttribution: Lars Toomre commentedGrr... Need to remember to set the right status!
Comment #3
Lars Toomre CreditAttribution: Lars Toomre commentedWhile performing a manual review with patch applied, I see that I missed adding a @throws directive to docblock for breakpoint_get_theme_media_queries(). This needs to be added in the next roll of this patch.
Comment #5
Lars Toomre CreditAttribution: Lars Toomre commentedThe @param directive for $group_id in _breakpoint_delete_breakpoint_groups() was wrong. Changed it from array to string and removed array from function declaration. Here is a re-rolled patch for the bot.
Comment #5.0
Lars Toomre CreditAttribution: Lars Toomre commentedAdded the follow-up issues list.
Comment #6
RainbowArrayIs this issue and the listed follow-up issues still relevant? The follow-up issues mention the 7.x-2.x version, and there's been a fair amount of mixup work on breakpoint module since this issue over a year ago.
Are these things we need to double-check to see if the fixes have been made?
Comment #7
attiks CreditAttribution: attiks commentedPostponing since the whole system of breakpoints is going to change, see #2271529: Move breakpoint settings to theme and module *.breakpoints.yml files at root level
Comment #8
attiks CreditAttribution: attiks commentedClosing since this is no longer relevant, see #2271529: Move breakpoint settings to theme and module *.breakpoints.yml files at root level