Facebook Share icon not working / title-attribute issue [#1821610]

Eventhough it shows up in the "Edit socialmedia_share-default set" page (admin/structure/widgets/sets/edit/socialmedia_share-default), it won't show up on the pages of my website nor in the "Social media share widget" page (admin/config/media/socialmedia/widgets/share).

It's not a broken image issue, since there's no Facebook-link at all on the page (there's no single trace of anything related to a Facebook share button). So I guess the issue resides a little deeper. I did clear the cache (Drupal & browser) to no avail.

Any advice?

Comment	File	Size	Author
#6	socialmedia-fb-share-titles-1821610-6.patch	2.56 KB	scottm316
#5	socialmedia-fb_share_alt-1821610-#3.patch	2.56 KB	invisibleink
#2	Title attribute Facebook icon	14.13 KB	knalstaaf
	Totally excluded on regular site pages (not a broken image-issue)	11.86 KB	knalstaaf
	Odd appearance on ">Social media share widget" page	21.8 KB	knalstaaf
	Shows up at "Edit socialmedia_share-default set" page	23.76 KB	knalstaaf

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

knalstaaf CreditAttribution: knalstaaf commented 24 October 2012 at 20:19

Status:

Active

» Closed (works as designed)

For some reason an update of the Chaos Tools module solved the problem.

Comment #2

knalstaaf CreditAttribution: knalstaaf commented 24 October 2012 at 20:28

Status:

Closed (works as designed)

» Needs review

File	Size
Title attribute Facebook icon	14.13 KB

Must say that the odd appearance on the "Social media share widget" page persists, but at least the icon appears for the visitors now. Strange title-attribute though: Visit [socialmedia:sm-facebook_username] on Facebook (doesn't sound too share-ish).

Comment #3

knalstaaf CreditAttribution: knalstaaf commented 26 March 2013 at 18:50

Title:

Facebook Share icon not working / title-attribute issue

» Facebook Share icon not working / appearing

I modified line 131 and 132 of socialmedia.widgets.inc by replacing $title with $stitle.

These look like this now:

'share-text-link' => '<a href="http://www.facebook.com/sharer.php?u=[|[node:url]||[current-page:url]|]&t=[|[node:title]||[current-page:title-plain]|]" title="[?link-text=Share on Facebook?]"[?link-target= target="{[socialmedia:sm-default_link_target_sharing]}"?][?link-rel= rel="{[socialmedia:sm-default_link_rel_sharing]}"?]>[?link-text=' . $stitle . '?]</a>',
    'share-button' => '<a href="http://www.facebook.com/sharer.php?u=[|[node:url]||[current-page:url]|]&t=[|[node:title]||[current-page:title-plain]|]" title="' . $stitle . '"[?link-target= target="{[socialmedia:sm-default_link_target_sharing]}"?][?link-rel= rel="{[socialmedia:sm-default_link_rel_sharing]}"?]><img src="[?icon-path=[socialmedia:sm-facebook_icon-path]?]" alt="Facebook icon" ></a>',

This solved the issue with the title attibute on the Facebook Share icon.

The issue with the missing FB icon on the "Social media share widget" page seems to be solved now as well (probably related to the code modification above).

I guess this should be committed, no?

Comment #4

knalstaaf CreditAttribution: knalstaaf commented 24 October 2012 at 21:16

Title:	Facebook Share icon not working / appearing	» Facebook Share icon not working / title-attribute issue
Version:	7.x-1.0-beta13	» 7.x-1.x-dev

Comment #5

invisibleink CreditAttribution: invisibleink commented 19 November 2012 at 16:31

File	Size
socialmedia-fb_share_alt-1821610-#3.patch	2.56 KB

Thanks so much for tracking this down. I rolled a patch in case that would be helpful to anyone....

Comment #6

scottm316 CreditAttribution: scottm316 commented 31 January 2013 at 06:40

File	Size
socialmedia-fb-share-titles-1821610-6.patch	2.56 KB

The "Visit ____ on Facebook" when using the sharing button was bothering me too. I had fixed this for myself but saw this old issue and noticed the attached patch in #5 is broken, 404. Could be because of the hashtag in the patch name? Tiny tiny fix. In this patch.