At Pantheon, we use extensive caching around image_get_info() to avoid network file system traffic. Calling getimagesize() bypasses this cache with bad consequences for users browsing many images through IMCE.
For quick reference, this is the call we'd like it to use:
http://api.drupal.org/api/drupal/includes%21image.inc/function/image_get...
Making excessive calls to getimagesize() and related file system functions on network mounts is a known problem that even has its own module for certain cases: http://drupal.org/project/imageinfo_cache
Pantheon will award a bounty of $100 for getting this simple fix into stable releases of IMCE for Drupal 6 and 7 by November 8, 2012.
The included patch is for Drupal 7.
Comment | File | Size | Author |
---|---|---|---|
#1 | imce_image_get_info.patch | 1.68 KB | ufku |
imce_image_get_info.patch | 1.22 KB | David Strauss | |
Comments
Comment #0.0
David Straussphrasing
Comment #0.1
David Straussphrasing
Comment #0.2
David Straussdeadline
Comment #0.3
David StraussD6
Comment #1
ufku CreditAttribution: ufku commentedFor the majority of drupal installations imce_image_info is faster than image_get_info. I'm not willing to change how it works though I can provide a way to switch to image_get_info.
The patch allows to switch between two versions of the function by checking a variable.
Comment #2
David StraussThat would be perfect. We can set that variable for our users to make use of the cache. Happy to pay the bounty for the proposed patch getting committed and made available in a stable release.
Thanks!
Comment #3
ufku CreditAttribution: ufku commentedCommitted to dev branches. No need for the bounty. Thanks.
Comment #4
David StraussAwesome! Do you know when we can expect this to make it into a release? I mostly posted the bounty to encourage an update to the stable release, which is currently just over a year old.
Comment #5
ufku CreditAttribution: ufku commentedI'll review a few more issues in the following days, after which I plan to make a new release.
Look to its coming, at first light, on the fifth day.
Comment #6
David Strauss:-)
Comment #7.0
(not verified) CreditAttribution: commentedDate