Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
They are too large, per the attached sreenshot.
Comment | File | Size | Author |
---|---|---|---|
#14 | recent-activity-picture.png | 136.73 KB | rosemeria |
#9 | 1823318.user_avatar_image_style_tokens.patch | 4.48 KB | jpontani |
#7 | 1823318.commons_activity_stream.user_picture_style_tokens.patch | 4.48 KB | jpontani |
commons_image_style.png | 155.67 KB | ezra-g |
Comments
Comment #1
ezra-g CreditAttribution: ezra-g commentedAnd the sitewide contributors block should use larger images.
Comment #2
ezra-g CreditAttribution: ezra-g commentedTagging for Beta1.
Comment #3
ezra-g CreditAttribution: ezra-g commentedSee #1868250: User pictures in Contributors block need better proportions for an example of why this is important.
Comment #4
jpontani CreditAttribution: jpontani commentedComment #5
japerryNot sure when it happened, but this is fixed!
Comment #6
ezra-g CreditAttribution: ezra-g commentedThese are currently being styled by the theme, not an image style. As a result, we're sending extra data over the pipe.
Comment #7
jpontani CreditAttribution: jpontani commentedAttached a patch that adds tokens for user picture using image styles that are available. The patch also changes the default messages included in activity streams feature to use 35x35 image style.
Comment #8
ezra-g CreditAttribution: ezra-g commentedLet's review for 3.2.
Comment #9
jpontani CreditAttribution: jpontani commentedPatch re-roll, as the previous patch no longer applies.
Comment #10
jpontani CreditAttribution: jpontani commentedActivity stream pictures now use 35x35 image style.
http://drupalcode.org/project/commons_activity_streams.git/commit/7ce0c86
Still need to change contributor and node creator images.
Comment #11
jpontani CreditAttribution: jpontani commentedhook_update_N implementation to revert the message types. Makes sure the new image styles are taken into account.
http://drupalcode.org/project/commons_activity_streams.git/commitdiff/69...
Comment #12
japerrylooks good to me!
Comment #13
rosemeria CreditAttribution: rosemeria commentedMessage when a wiki page has been updated on activity stream-- needs square 35 x 35 picture fix too.
Thanks
Comment #14
rosemeria CreditAttribution: rosemeria commentedUser image in activity stream formatted differently for "wiki updates" img class="image-style-thumbnail" should be 35x35. You can only catch this minor design issue if user profile picture uploaded is not square.
Comment #15
jpontani CreditAttribution: jpontani commentedRetitling
Comment #16
jpontani CreditAttribution: jpontani commentedCommitted.
http://drupalcode.org/project/commons_wikis.git/commitdiff/a4c5ad7