If I define multiple replica set servers in mongo connections settings mdbc will choke and die trying to connect to "192.168.0.1,192.168.0.2" if replica set option is enabled drush should figure out which is primary and connect to that one by default and also allow option for user to connect to any of the secondaries.

CommentFileSizeAuthor
#13 1823478-replicasets_connection-13.patch6.27 KBfgm
#11 1823478-replica_sets-11.patch6.6 KBfgm
#9 mdbc_replica-2823478-9.patch6.54 KBalasda
#8 mdbc_replica-1823478-8.patch6.01 KBalasda
#7 drush_command_line-1823478-7.patch7.29 KBdisasm
#2 mdbc_replica-1823478-2.patch3.5 KBRok Žlender
#1 mdbc_replica-1823478-1.patch2.82 KBRok Žlender
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Rok Žlender’s picture

Rok Žlender CreditAttribution: Rok Žlender commented
Status: Active » Needs review
FileSize
mdbc_replica-1823478-1.patch2.82 KB

Patch supports running drush command on replica set configuration options.

Rok Žlender’s picture

Rok Žlender CreditAttribution: Rok Žlender commented
FileSize
mdbc_replica-1823478-2.patch3.5 KB

Revisited patch created new constant for primary member status value and added a msg to users when connecting to secondary how to send queries against it.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
Issue summary: View changes
Status: Needs review » Needs work

Patch no longer applies, so setting CNW. This is not just a matter of rerolling : the connection process changed in 3 years.

At this point, drush mdbc does not even work on a standalone host.

  • fgm committed 474ddf8 on 7.x-1.x 
    Issue #1823478: first step of fix: fixed drush commands no longer...
fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented

The commit above restores mdbc and the other drush operations on single hosts : the patch is still needed for replicasets.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
Related issues: +#1930822: drush mongo shell host scheme error

The connection string issue with authenticated users had another partial patch on #1930822: drush mongo shell host scheme error, probably good to merge with this one.

disasm’s picture

disasm CreditAttribution: disasm at AppliedTrust commented
Status: Needs work » Needs review
FileSize
drush_command_line-1823478-7.patch7.29 KB

I ended up rerolling this to get it to work with mongo 3.x client which no longer likes the old ; separated params. Here's a patch.

alasda’s picture

alasda CreditAttribution: alasda commented
FileSize
mdbc_replica-1823478-8.patch6.01 KB

Rolls together Rok Zlender and disam's patches against current head. Fixes a few formatting and coding standards issues.

alasda’s picture

alasda CreditAttribution: alasda commented
FileSize
mdbc_replica-2823478-9.patch6.54 KB

Fixes a couple missed formatting issues from previous patch.

marcingy’s picture

marcingy CreditAttribution: marcingy at Examiner.com commented
Status: Needs review » Reviewed & tested by the community
fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
Status: Reviewed & tested by the community » Needs review
FileSize
1823478-replica_sets-11.patch6.6 KB

Patch no longer applied : rerolled on today's HEAD for review.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
Status: Needs review » Needs work 
  1. +++ b/mongodb.drush.inc
@@ -111,15 +107,9 @@ function drush_mongodb_connect($alias = 'default') {
+  drush_print(proc_close(proc_open(escapeshellcmd($command), array(0 => STDIN, 1 => STDOUT, 2 => STDERR), $pipes)));

    Any reason to wrap this on a single too long line ? I find it less readable, and if kept, the array needs to be multiline anyway, as per coding standards. 

  2. +++ b/mongodb.drush.inc
@@ -132,12 +122,84 @@ function _drush_mongodb_connect($alias) {
+  // If we are dealing with connection to replica set by default connect

    The whole code in this function is replicating/replacing code from the mongodb() function in the main module, but missing some functionality like supporting debug and returning MongoDummy on failures. We should not have two different connection methods : if the RS support in this method is better than the one in mongodb(), it needs to be merged there, not duplicated here. 

  3. +++ b/mongodb.drush.inc
@@ -132,12 +122,84 @@ function _drush_mongodb_connect($alias) {
+  // selected secondary member lets notify users how to send queries against

    Seeing the code on the next lines, "lets" should probably be "then" ? As such, the sentence is not clear 

  4. +++ b/mongodb.module
@@ -4,6 +4,10 @@
+define("MONGODB_REPLICA_SET_PRIMARY", 1);

    This constant is not used anywhere, so it should probably be removed. 

  5. +++ b/mongodb.module
@@ -4,6 +4,10 @@
+define("MONTODB_SLAVE_NOT_CONNECTED", 1);

    This constant looks like it has a typo, and it is used as MONGODB_SLAVE_NOT_CONNECTED, not with the typo, so it needs to be changed.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
Status: Needs work » Needs review
FileSize
1823478-replicasets_connection-13.patch6.27 KB

Rerolled on top of today's HEAD, also addressing all points except 2.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
Related issues: +#2644482: PHP 7 driver support

Also, note that this patch will need to be compatible with #2644482: PHP 7 driver support, which may have consequences since the parsing of connection strings may be different between the legacy mongo extension used by this version of the patch, and the current mongodb extension used with PHP 7 and earlier versions of PHP with the alcaeus adapter.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented

PR is on https://github.com/fgm/mongodb/pull/65