Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
ConfigStorageController::save() currently assumes that only and all public properties are to be written to storage.
This gives no opportunity to remove public properties from the export, or more importantly, to add in protected properties via a getter method.
Comment | File | Size | Author |
---|---|---|---|
#1 | drupal-1824484-1.patch | 1.97 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettThis just moves the current code out of the middle of save() and into it's own method.
Comment #2
dawehnerCouldn't we use ConfigEntityInterface here, as the config storage controller will also just care about that.
Comment #3
tim.plunkettWe use EntityInterface for everything else, and it would just mean another class to
use
when overriding it.Comment #4
dawehnerSo we could do that globally later as a follow up.
The rest is just pure c&p and used by all tests already.
Comment #5
damiankloip CreditAttribution: damiankloip commentedYep, agreed.
Comment #6
tim.plunkettThis isn't really a "feature request", but an necessary API improvement. We just discussed at the sprint and this is definitely a task.
Comment #7
webchickCommitted and pushed to 8.x. Thanks!