Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This patch includes a preprocess function in addition to a twig template.
Comment | File | Size | Author |
---|---|---|---|
#4 | d8tts-menu-local-action-2.patch | 1.41 KB | EVIIILJ |
d8tts-menu-local-action.patch | 1.39 KB | EVIIILJ |
Comments
Comment #1
podaroklooks good
RTBC
Thanks!
commited / pushed to front-end
Comment #2
vlad.dancerreplace by template_preprocess, now this patch throws error.
Also add &$variables
I suppose to replace this by just variables for theme_link and use below in template {{ include "link.html.twig" }}
Comment #3
podarokhttp://drupalcode.org/sandbox/pixelmord/1750250.git/commit/d680b6f
Comment #4
EVIIILJ CreditAttribution: EVIIILJ commented#2 - (1) I correctly renamed theme_ to template_preprocess
#2 - (2) Do you think we need to segregate the
l()
link variable from the other two HTML text andhtmlspecialchars()
versions that were initially outputted by the theme_ function?Comment #5
vlad.dancerNeeds work
Due to jenlampton comment here
Could you mention your point here about doc block
Comment #6
decafdennis CreditAttribution: decafdennis commented@vlad.dancer:
Can you clarify what this...
...has to do with #1819414-9: Convert theme_user_admin_roles?
Comment #7
steveoliver CreditAttribution: steveoliver commentedChanging title; assigning myself, in preparation for menu.inc patch in #1898478: menu.inc - Convert theme_ functions to Twig.
Comment #8
steveoliver CreditAttribution: steveoliver commentedClosing this (instead of moving it to core queue) in favor of aggregated 'menu.inc' core issue #1898478: menu.inc - Convert theme_ functions to Twig. Git attributions to all participants will happen there.