This is a sub-task of http://drupal.org/node/1775842 Convert all variables to state and/or config systems.

CommentFileSizeAuthor
#4 1824834-default_nodes_main-cmi-2.patch3.46 KBvijaycs85
#2 default_nodes_main_cmi-1824834-1.patch3.09 KBAlbert Volkman
#1 1824834-default_nodes_main-CMI-1.patch3.46 KBvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs review
FileSize
1824834-default_nodes_main-CMI-1.patch3.46 KB

As discussed with @alexpott, We are changing the variable "default_nodes_main" to "items_per_page" to maintain the consistency of naming convention with views.

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
FileSize
default_nodes_main_cmi-1824834-1.patch3.09 KB

Ooops, xpost. Nevermind :)

Status: Needs review » Needs work

The last submitted patch, default_nodes_main_cmi-1824834-1.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review
FileSize
1824834-default_nodes_main-cmi-2.patch3.46 KB

Recommitting the success patch.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Assigned: vijaycs85 » Unassigned
gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
CreditAttribution: gdd commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, thanks!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

This will go away in #1806334: Replace the node listing at /node with a view but is fine for now.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.