Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a child of #1775842: [meta] Convert all variables to state and/or config systems
Original issue where this variable was introduced: #318636: Make l() themable (see comment #57)
Comment | File | Size | Author |
---|---|---|---|
#26 | system-update.patch | 455 bytes | xjm |
#25 | drupal8.theme-link-config.25.patch | 455 bytes | sun |
#22 | interdiff.txt | 618 bytes | Cameron Tod |
#21 | 1824920-cmi_convert-theme-link-20.patch | 2.17 KB | Cameron Tod |
#19 | 1824920-cmi_convert-theme-link-19.patch | 1.57 KB | Cameron Tod |
Comments
Comment #1
Cameron Tod CreditAttribution: Cameron Tod commentedComment #2
Cameron Tod CreditAttribution: Cameron Tod commentedHere we go.
Comment #3
aspilicious CreditAttribution: aspilicious commentedWhat does theme_link do?
Comment #4
Cameron Tod CreditAttribution: Cameron Tod commentedl() can either render links inline, or pass through theme_link() Rendering a link inline in l() is faster than using theme_link(). Because l() is so heavily used, using theme_link() can add a lot of overhead to page views, so by setting theme_link to FALSE you can disable theme_link entirely.
Here's the inline comment:
You can see this comment for effulgentsia's numbers on this.
Comment #5
aspilicious CreditAttribution: aspilicious commentedOk for me this is good to go in that case.
Comment #6
catchI'm not sure this should go in the same place as the list of enabled themes, it seems a bit mis-placed there. Bumping back to CNR.
Comment #7
Cameron Tod CreditAttribution: Cameron Tod commentedMoved into system.performance.
Comment #8
Cameron Tod CreditAttribution: Cameron Tod commentedUm, don't know what is up with that interdiff :/
Comment #9
catchsystem.performance is a great idea for this one!
Comment #10
catch#7: 1824920-cmi_convert-theme-link-variable-7.patch queued for re-testing.
Comment #12
Cameron Tod CreditAttribution: Cameron Tod commentedOK, will reroll.
Comment #13
Cameron Tod CreditAttribution: Cameron Tod commentedComment #15
justafishBumping system update number
Comment #16
aspilicious CreditAttribution: aspilicious commentedNumber is way higher again! Srry!
Comment #17
Cameron Tod CreditAttribution: Cameron Tod commentedRerolled against current head, bumped update number even higher.
Comment #19
Cameron Tod CreditAttribution: Cameron Tod commentedThe same test is failing here, but I have rerolled with a new system update in the meantime. Investigating.
Comment #21
Cameron Tod CreditAttribution: Cameron Tod commentedThanks to timplunkett for the help!
Comment #22
Cameron Tod CreditAttribution: Cameron Tod commentedHere's an interdiff of the changes to the test that was failing before.
Comment #23
ACF CreditAttribution: ACF commentedLooks good to go, agreed it should be in performance.
Comment #24
catchCommitted/pushed to 8.x, thanks!
Comment #25
sunComment #26
xjmMissed an update hook addition.
Comment #27
xjmlol. Crosspost.
Comment #28
catchWhoops. I credited both of yer.
Comment #29
xjmThanks!
Comment #30.0
(not verified) CreditAttribution: commentedwas linking to wrong meta issue