Comments

StatusFileSize
new6.26 KB

First pass at integration.

This will be included in the Spark distribution 8.x alpha build.

StatusFileSize
new6.39 KB

That patch in #1 doesn't apply to the 8.x-1.0-alpha1 tag. Rerolling.

StatusFileSize
new6.38 KB

I neglected to move an if statement that prevents the Edit tab from loading on pages that are not editable.

The first change of http://drupalcode.org/project/edit.git/commitdiff/e8324b5 may but should not conflict with the patch in #3.

I LOVE how we're no longer relying on hook_page_alter() :)

Why also include the icons as data URIs though?

StatusFileSize
new5.5 KB

This no longer applied to me against the latest Edit module code. Here's an attempt at a re-roll.

StatusFileSize
new5.53 KB

Attempting a hand-edited patch. Here goes. The icon CSS is now incorrect because of changes to the Toolbar CSS.

StatusFileSize
new5.79 KB

Ok, one more time.

Wim recommended we stick with the alpha1 release in Spark for now, as Edit module's still in flux. This means going back to the patch in #3 with the icon fix from #6. Attempting to do that here in #7.

StatusFileSize
new5.82 KB

Lucky try #2? (or #8 in this case?)

Status:Active» Closed (fixed)

Updated patch has been posted to #1137920: Fix toolbar on small screen sizes and redesign toolbar for desktop. This issue is no longer needed.

Status:Closed (fixed)» Needs work

StatusFileSize
new6.12 KB

Updated patch.

+++ b/edit.moduleundefined
@@ -79,18 +97,9 @@ function edit_page_alter(&$page) {
-  global $editbar;

Edit sets global $editbar = TRUE (see edit_preprocess_field()) to ensure the view/edit mode toggle ONLY shows up if there's actually something on the page that's editable.

I know, it's crappy and evil, but it's also KISS for now.

If you can take that one thing into account, then this looks GREAT :)

This patch needs a refresh for the new toolbar (now hook_toolbar() instead of hook_toolbar_something_something()) and new Edit module patch available at #1824500-9: In-place editing for Fields.

StatusFileSize
new6.09 KB

Here's #11 with hook_toolbar() renamed. Testing.

StatusFileSize
new6.09 KB

Here's #11 with hook_toolbar() renamed. Testing.

StatusFileSize
new7.87 KB

Ok, new patch. Includes fix for CSS and maybe some other things.

StatusFileSize
new7.16 KB

Includes integration with the latest D8 toolbar patch as of #1137920-290: Fix toolbar on small screen sizes and redesign toolbar for desktop.

Status:Needs work» Needs review

wellll, shitballs. :( I didn't realize the latest Edit module code wasn't in git, and is instead only in the patch at http://drupal.org/node/1824500#comment-6741906, and when switching to the patch at http://drupal.org/files/in_place_editing_for_fields-9.patch this patch of course no longer applies. I tried applying it manually and now we're back to that lovely thing where it's linking to URL/%23 and getting a 404 and therefore not invoking view/edit mode. UIY@*#&(@#&@# anyway, let's discuss when you're up. ;)

Status:Needs review» Needs work

#18: that's because I didn't merge the node/1824100-createjs-d8 branch back into the 8.x-1.x branch yet (I was exhausted when I rolled that patch on Friday). No worries though, the server-side part has not changed in any meaningful way, so it'll be easy enough to port over your patch :)

FYI, the node/1824100-createjs-d8 branch has been merged back into the 8.x-1.x branch; I'm currently testing Spark + this patch.

Status:Needs work» Needs review
StatusFileSize
new5.34 KB

Rerolled; now it is working. (The difference: I'm setting the URL fragments; that's how it works now :))

  • Note that this removes the ugly, but functional way of ensuring no view/edit mode toggle appears if there is nothing to edit. Are we sure this is what we want? I'm fine with either, as long as it's conscious.
  • Is it intentional that menu items in the toolbar that are "active" (i.e. have the "active" class) are *not* styled differently?

StatusFileSize
new7.23 KB

Now *with* icons.

Here's a "Drupal core patch" version of the patch in #23, for use in the Spark distro.

StatusFileSize
new7.59 KB

Reintroduce the #post_render callback, as mentioned in #22.1 after discussing with @webchick and @Jesse Beach.

Note for #25: the #post_render callback is only called for the tray, not for the tab. In other words: the Edit tab is always present, even if zero editable fields exist on the page.

StatusFileSize
new38.88 KB
new41.7 KB

Before:
before.png

After:

after.png

conditionally rendering the Edit module tab is blocked on: #1847198: Update the structure returned by hook_toolbar()

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Added the dev branch info.