A couple of small fixes

CommentFileSizeAuthor
#1 Coding_standards-1825546-1.patch22.08 KBram4nd
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ram4nd’s picture

ram4nd CreditAttribution: ram4nd commented
Component: Miscellaneous » Code
FileSize
Coding_standards-1825546-1.patch22.08 KB

I have made a patch to fix most of coding standard errors.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
CreditAttribution: xurizaemon commented

Looks great. Can I ask why php = 5.1 is removed from the .info here - did it trigger a coding standards error, or was that something else?

AFAIK that's valid, even if the required PHP referred to is old. .info file format

Thanks again, looks like it's mostly whitespace but I'll try to test soon.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
CreditAttribution: xurizaemon commented
Status: Active » Needs review
ram4nd’s picture

ram4nd CreditAttribution: ram4nd commented

It did trigger an error, mostly whitespace and indent conversion. But the php version gave an error, and the explanation was that Drupal 7 requires 5.2 itself.