Add default notifiers to the main module, and be able to edit it through the UI module.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Moo64c’s picture

Needs the patch for message notify to work:
http://drupal.org/node/1825962#comment-6662668

Moo64c’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, default-notifiers-1825882-1.patch, failed testing.

Moo64c’s picture

Reroll.

Moo64c’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, default-notifiers-1825882-4.patch, failed testing.

Moo64c’s picture

Rerolled and fixed tests.

Moo64c’s picture

Status: Needs work » Needs review
amitaibu’s picture

Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

japerry’s picture

Category: task » bug
Status: Closed (fixed) » Needs work

Unfortunately this patch, with an email set as default, makes it impossible to override the default notifications setup.

In commons, we have message_subscribe_email do the emailing if people elect to have an email sent to them. In the current setup, as soon as you follow someone it'll start emailing you, regardless of if you have the email flag set.

See: #2001702: Message Subscribe sends emails regardless of flag checkmarks in notification-settings for more information.

For now we're setting the array to null, but the UI should have a way to uncheck this option. If message_subscribe_email is enabled, we may want to set this setting differently.

Marking needs work.

  • amitaibu committed 9801fae on 8.x-1.x authored by Moo64c
    Issue #1825882 by Moo64c: Add default notifiers option.
    
joelpittet’s picture

Issue summary: View changes
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.