I can't for the life of me figure out what the html5.js and html5-respond.js files are. But they both have a comment at the top that says "Uncompressed source: https://github.com/aFarkas/html5shiv". So I *think*
html5.js == html5shiv.js
html5-respond.js seems to be that plus some other stuff (not sure what though or where it comes from).

Why rename these files?

CommentFileSizeAuthor
#5 zen-1826988-5.patch33.95 KBMustangGB
#4 zen-1826988-4.patch27.11 KBMustangGB
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Title: Do not rename HTML5shiv JS files » Rename HTML5.js back to original html5shiv.js
Category: bug » task

I didn't rename the files. They used to be called html5.js. See https://code.google.com/p/html5shiv/source/browse/#svn%2Ftrunk

And html5-respond.js is an aggregation of the html5.js and respond.js files.

Unfortunately, I can't simply rename it from html5.js to html5shiv.js without breaking those sub-themes that have overridden Zen's html.tpl.php file.

So, we'd have to have a solution for those users before proceeding.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Title: Rename HTML5.js back to original html5shiv.js » Rename HTML5.js to html5shiv.js to avoid confusion
JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Version: 7.x-5.x-dev » 7.x-6.x-dev

How about we just fix it in the next branch?

MustangGB’s picture

MustangGB CreditAttribution: MustangGB commented
Title: Rename HTML5.js to html5shiv.js to avoid confusion » Rename HTML5.js to html5shiv.js to and update html5shiv.js and respond.js to latest versions
Issue summary: View changes
FileSize
zen-1826988-4.patch27.11 KB
MustangGB’s picture

MustangGB CreditAttribution: MustangGB commented
FileSize
zen-1826988-5.patch33.95 KB

This time with a few code changes to Zen to reflect the change.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Title: Rename HTML5.js to html5shiv.js to and update html5shiv.js and respond.js to latest versions » Rename HTML5.js to html5shiv.min.js and update html5shiv.js to latest version
Status: Active » Needs review

  • JohnAlbin committed 55a24eb on 7.x-6.x authored by MustangGB 
    Issue #1826988 by MustangGB: Rename HTML5.js to html5shiv.min.js and...
JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Status: Needs review » Fixed

Fixed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.