Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
We have a lot of Drupal\user\User
, Drupal\node\Node
, etc.. references lying around after #1763974: Convert entity type info into plugins, let's fix them.
Some usages are actually bugs at this point (use Drupal\user\User;
). This should also help a lot when/if we decide to shorten the naming convention.
Comment | File | Size | Author |
---|---|---|---|
#5 | 1828852-update_entity_classes-5.patch | 78.31 KB | amateescu |
#5 | interdiff-0-5-do-not-test.patch | 2.95 KB | amateescu |
updated_entity_classes.patch | 77.01 KB | amateescu | |
Comments
Comment #2
andypostupdated_entity_classes.patch queued for re-testing.
Comment #3
sunComment #4
tim.plunkettNone of these should be inline like that, they should all have
use
statements.The rest is all docs, but those 3 above are worrying. A sign of no test coverage?
Comment #5
amateescu CreditAttribution: amateescu commentedFixed #4.
Comment #6
tim.plunkettChecked with git diff --color-words, looks good.
Comment #7
catchI've re-opened the other patch for more discussion, postponing this one.
Comment #8
tstoecklerActually this actually just makes the status quo consistent. I don't see a reason not to commit this, even if we end up changing the implementation. I fear that when we decide to roll that one back, that it won't be able to revert cleanly anyway, and this will make it easier to grep for "Plugin/Core/Entity". Moving back to RTBC. I don't feel strongly here, though, so in case someone marks it back I won't mind.
Comment #9
catchOK no I actually think this is weird. We're not using real plugins for entities, just annotation discovery, so having the class name in the Plugin namespace is confusing.
Comment #10
tim.plunkettI've opened #1847002: Move entity type classes from Drupal\$provider\Plugin\Core\Entity to Drupal\$provider\Entity as the issue to deal with that.
Comment #11
Berdir5: 1828852-update_entity_classes-5.patch queued for re-testing.
Comment #13
hussainwebIs this still relevant? I am hard-pressed to find even one instance of the issue described above in the latest HEAD. I guess it got sorted out with everything else? I am marking this as Closed (cannot reproduce) for now. Please reopen if you find this is incorrect.