There should be a test similar to HandlersAllTest which just CRUDs some handler to be it is working.

Files: 
CommentFileSizeAuthor
#7 1829822-7.patch4.3 KBdamiankloip
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1829822-7.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#4 vdc-1829822-4-FAIL.patch2.45 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vdc-1829822-4-FAIL.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#4 vdc-1829822-4-PASS.patch4.3 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vdc-1829822-4-PASS.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 vdc-1829822-3-FAIL.patch2.45 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 46,524 pass(es), 9 fail(s), and 0 exception(s).
[ View ]
#3 vdc-1829822-3-PASS.patch4.3 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vdc-1829822-3-PASS.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 interdiff.txt2.32 KBtim.plunkett
#1 drupal-1829822-1.patch3.71 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 46,521 pass(es), 75 fail(s), and 0 exception(s).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new3.71 KB
FAILED: [[SimpleTest]]: [MySQL] 46,521 pass(es), 75 fail(s), and 0 exception(s).
[ View ]

That is just a start, but sadly the tests aren't working yet.

Status:Needs review» Needs work

The last submitted patch, drupal-1829822-1.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.32 KB
new4.3 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vdc-1829822-3-PASS.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
new2.45 KB
FAILED: [[SimpleTest]]: [MySQL] 46,524 pass(es), 9 fail(s), and 0 exception(s).
[ View ]

Fixed the tests.

There are no valid relationship handlers for views_test_data yet.

StatusFileSize
new4.3 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vdc-1829822-4-PASS.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
new2.45 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vdc-1829822-4-FAIL.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

+++ b/core/modules/views/lib/Drupal/views/Tests/UI/HandlerTest.phpundefined
@@ -0,0 +1,62 @@
+      elseif ($type != 'relationship') {

Should have been ==

Priority:Normal» Major

This is test coverage we should have had already, it is central to the functionality of Views, and it blocks a couple other issues.

+++ b/core/modules/views/lib/Drupal/views/Tests/UI/HandlerTest.phpundefined
@@ -0,0 +1,62 @@
+      // Different handler types need to use different handlers.

Should this be Area handler types ...?

Other than that, looks good to go, and we need this one quite desperately.

Status:Needs review» Reviewed & tested by the community
StatusFileSize
new4.3 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1829822-7.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Rerolled with the minor doc change. I think it's good to go.

I totally agree, and we need this for other people which port the views parts of their changes.

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.