Files: 
CommentFileSizeAuthor
#6 1830848-2-translation_node_type_to_cmi.patch2.85 KBmtunay
PASSED: [[SimpleTest]]: [MySQL] 46,876 pass(es).
[ View ]
#4 1830848-1-translation_node_type_to_cmi.patch2.91 KBmtunay
PASSED: [[SimpleTest]]: [MySQL] 46,842 pass(es).
[ View ]
#1 1830848-0-translation_node_type_to_cmi.patch2.97 KBmtunay
PASSED: [[SimpleTest]]: [MySQL] 46,842 pass(es).
[ View ]

Comments

StatusFileSize
new2.97 KB
PASSED: [[SimpleTest]]: [MySQL] 46,842 pass(es).
[ View ]

First patch.. Hope it's ok..

Status:Active» Needs review

Test it please..:)

Status:Needs review» Needs work

the translation_ prefix can be removed, that is no longer necessary. Looks good otherwise.

Status:Needs work» Needs review
StatusFileSize
new2.91 KB
PASSED: [[SimpleTest]]: [MySQL] 46,842 pass(es).
[ View ]

Done...

+++ b/core/modules/translation/config/translation.settings.ymlundefined
@@ -0,0 +1 @@
+language_type: "language_interface"
\ No newline at end of file
+++ b/core/modules/translation/translation.installundefined
@@ -15,3 +15,16 @@ function translation_update_8000() {
+}
\ No newline at end of file

Make sure to add an empty line at the end of these two files so that git stops complaining about it.

+++ b/core/modules/translation/translation.installundefined
@@ -15,3 +15,16 @@ function translation_update_8000() {
     ->execute();
}
+
+
+/**
+* Moves "translation_language_type" from variable to config.

While you're at it, there is one empty line too much here, that's not necessary.

StatusFileSize
new2.85 KB
PASSED: [[SimpleTest]]: [MySQL] 46,876 pass(es).
[ View ]

Sorry

Status:Needs review» Reviewed & tested by the community
Issue tags:+Configuration system

Looks good, RTBC if the tests pass.

Status:Reviewed & tested by the community» Needs review

Like..

Status:Needs review» Reviewed & tested by the community

RTBCing.

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.