Created from #1775842: [meta] Convert all variables to state and/or config systems.

theme_settings
theme_$theme_settings

Files: 
CommentFileSizeAuthor
#8 theme_system_variables_to_config-1830978-8.patch2.19 KB8thom
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch theme_system_variables_to_config-1830978-8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#4 theme_system_variables_to_config-1830978-4.patch2.01 KB8thom
PASSED: [[SimpleTest]]: [MySQL] 47,286 pass(es).
[ View ]
#2 theme_system_variables_to_config-1830978-2.patch5.1 KB8thom
FAILED: [[SimpleTest]]: [MySQL] 46,900 pass(es), 13 fail(s), and 0 exception(s).
[ View ]
#1 theme_system_variables_to_config-1830978-1.patch5.09 KB8thom
FAILED: [[SimpleTest]]: [MySQL] 46,847 pass(es), 11 fail(s), and 4 exception(s).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new5.09 KB
FAILED: [[SimpleTest]]: [MySQL] 46,847 pass(es), 11 fail(s), and 4 exception(s).
[ View ]

First attempt...

StatusFileSize
new5.1 KB
FAILED: [[SimpleTest]]: [MySQL] 46,900 pass(es), 13 fail(s), and 0 exception(s).
[ View ]

Sorry didn't realise there was other issues that refer to these variables which are putting config into system.site,
updated patch to reflect this.

Status:Needs review» Needs work

Issue summary:View changes

included link to issue #1775842

Status:Needs work» Needs review
StatusFileSize
new2.01 KB
PASSED: [[SimpleTest]]: [MySQL] 47,286 pass(es).
[ View ]

Here it is, not too sure how to make update function for theme_$theme_settings, are there any examples of updating dynamic variables?

Status:Needs review» Needs work

The last submitted patch, theme_system_variables_to_config-1830978-4.patch, failed testing.

Status:Needs work» Needs review

StatusFileSize
new2.19 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch theme_system_variables_to_config-1830978-8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

This patch Include update function for theme_$theme_settings.

This is quite a complicated issue and the conversion has already been attempted in #1712250: Convert theme settings to configuration system. I'm tempted to mark this issue as a duplicate. The essential issue here is that theme settings should come from a configuration file and not be built from multiple configurations at runtime - at the moment theme settings are built from defaults in code, global settings in variable (which this patch converts), theme .info files and a theme specific variable.

Additionally the system.theme namespace is now used for enabled themes so we need to be careful about using it for this.

Status:Needs review» Needs work

The last submitted patch, theme_system_variables_to_config-1830978-8.patch, failed testing.

Component:configuration system» theme system
Issue tags:+Configuration system

Status:Needs work» Closed (duplicate)

Already fixed in the linked issue above

Issue summary:View changes

converted issue to cover theme_settings & theme_$theme_settings