Follow up for #1831530: Entity translation UI in core (part 2)

Problem/Motivation

cannot mark a translation as outdated. can only edit another translation and from there, check the box to more all other translations outdated, then edit every translation that is not meant to be outdated and uncheck the needs updating check box in those translations. ick.

Proposed resolution

show the "mark this outdated" on every translation (even ones where they are not outdated)

Remaining tasks

  • write down steps to reproduce exactly
  • get screen shots or find ones in #1188388: Entity translation UI in core to reuse
  • find comments in #1188388: Entity translation UI in core about this issue. link to them in Original report section below. There are several.
  • reroll (relevant part of) the patch from that issue in comment 188 and post it here
  • document usual workflows to decide how making outdated should be
  • code solution
  • update tests(?)
  • more screen shots
  • manually test
  • ui review new screen shots
  • code review

User interface changes

This is a ui issue. See above.

API changes

no api changes anticipated.

Original report

Link to original comments from et ui issue

CommentFileSizeAuthor
#34 1833096-nr-bot.txt132 bytesneeds-review-queue-bot
#23 1833096-23.patch7.74 KBLeksat
#23 1833096-interdiff-13-23.txt1.56 KBLeksat
#22 1833096-22.patch10.2 KBandrey.troeglazov
#19 1833096-19.patch9.29 KBandrey.troeglazov
#17 1833096-17.patch8.42 KBandrey.troeglazov
#13 1833096-13-test-only.patch4.66 KBLeksat
#13 1833096-13.patch7.75 KBLeksat
#5 1833096-5.png99.73 KBLeksat
#5 1833096-5.patch3.1 KBLeksat
#2 Screenshot from 2015-10-16 21:29:02.png83.87 KBmatsbla
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Component: translation_entity.module » content_translation.module
matsbla’s picture

matsbla CreditAttribution: matsbla commented
Issue summary: View changes
FileSize
Screenshot from 2015-10-16 21:29:02.png83.87 KB

What about making it possible to mark only 1 specific translation as outdated?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Leksat’s picture

Leksat CreditAttribution: Leksat at Amazee Labs commented
Issue summary: View changes
Status: Active » Needs review
FileSize
1833096-5.patch3.1 KB
1833096-5.png99.73 KB

With this patch:
- both checkboxes are always visible
- the order of checkboxes is changed ("This translation needs to be updated" seems to be more important)
- ContentTranslationHandler::retranslate() does what its documentation says

I vote for this change because current workflow is quite confusing for content editors. They want full control over the Outdated flags.

matsbla’s picture

matsbla CreditAttribution: matsbla commented

I tested this now - looks great!
++1!

Luxian’s picture

Luxian
he/him
Primary language Romanian
Location Zurich Area
CreditAttribution: Luxian at Amazee Labs commented
Status: Needs review » Reviewed & tested by the community

Tested this on production website, works as expected. I think it's safe to say it RTBC.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

Thanks everyone!

Can we add some automated test coverage for this improvement?

The help text is also really long which has a detrimental impact on usability, but looks like the strings are the same as in HEAD so that can be considered out of scope.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: +sprint

Agreed with the goal of the issue, moving onto D8MI sprint. Agree it needs tests.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Title: get good workflow for dealing with translations being marked outdated » Cannot mark a translation itself as outdated

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

matsbla’s picture

matsbla CreditAttribution: matsbla commented

Should there maybe be a permission setting for who can mark this (or other) translations as outdated?

Leksat’s picture

Leksat CreditAttribution: Leksat at Amazee Labs commented
Status: Needs work » Needs review
FileSize
1833096-13.patch7.75 KB
1833096-13-test-only.patch4.66 KB

I have updated the existing test.
(test-only == interdiff to 5)

Status: Needs review » Needs work

The last submitted patch, 13: 1833096-13-test-only.patch, failed testing.

Leksat’s picture

Leksat CreditAttribution: Leksat at Amazee Labs commented
Status: Needs work » Needs review
Leksat’s picture

Leksat CreditAttribution: Leksat at Amazee Labs commented
Issue tags: -Needs tests
andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi for Globalbility commented
FileSize
1833096-17.patch8.42 KB

Hello,
I`ve added permissions logic as mentioned in #12.
Also @Leksat you used array() instead [] in you patch which is deprecated in D8, so I`ve changed it.

Status: Needs review » Needs work

The last submitted patch, 17: 1833096-17.patch, failed testing.

andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi for Globalbility commented
FileSize
1833096-19.patch9.29 KB

Rerolled the patch with adding a new permission to the tests.

andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi for Globalbility commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 19: 1833096-19.patch, failed testing.

andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi for Globalbility commented
Status: Needs work » Needs review
FileSize
1833096-22.patch10.2 KB
Leksat’s picture

Leksat CreditAttribution: Leksat at Amazee Labs commented
FileSize
1833096-interdiff-13-23.txt1.56 KB
1833096-23.patch7.74 KB

@andrey.troeglazov, I believe adding a permission would be out of scope for this issue. Because it may need an update path and/or a change record. Can you please create a new issue for that?

In this patch:
- changed array() to []
- rerolled on 8.3.5

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

matsbla’s picture

matsbla CreditAttribution: matsbla commented

Have set up a small module that implements it while we wait for this to be fixed in core Outdated Translation

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commented
Status: Needs review » Needs work
FileSize
1833096-nr-bot.txt132 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.