In issue #1833716: WYSIWYG: Introduce "Text editors" as part of filter format configuration, we introduce a new filtering system that provides all the bindings between the backend filtering and the front-end text format fields. This change means that we can remove the majority of code from Aloha module as it is moved into Filter module.

This patch doesn't include it, but we can also entirely delete the includes/format.inc file.

Comments

StatusFileSize
new30.64 KB

Here's a revised patch that works with #1833716-7: WYSIWYG: Introduce "Text editors" as part of filter format configuration.

I moved the detection of possible tags back into Aloha module because I couldn't find a strong case for keeping it in Filter module. The main reason the detection of tags exists is to determine the button layout of Aloha, but I think we need to flip this around so that the user chooses buttons and that provides the available tags. However since detecting tags is the way Aloha works, it needs this functionality for the time being. I rewrote it to be more complete with the HTML spec, though Aloha doesn't have the ability to edit most tags at this point. The resulting code is more clear to read though, so perhaps it would be good to add that functionality separately to Aloha.

Thanks for the patch! :)

Temporarily marking as postponed until we have sorted out #1833716: WYSIWYG: Introduce "Text editors" as part of filter format configuration.

Status:Needs review» Postponed