Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When eval'ing a template, you say that $r holds the values, but since you generate a code string and pass it to drupal_eval, drupal_eval has no knowledge of $r and so it can't be eval'd. I did the output buffering and eval'ing inline so that you have access to the $r array. I'm not sure this is the best way to do this, but it works.
Comment | File | Size | Author |
---|---|---|---|
#5 | 183379.patch | 878 bytes | roychri |
#3 | 183379.patch | 664 bytes | roychri |
site_user_list.patch | 834 bytes | chrisfromredfin |
Comments
Comment #1
pukku CreditAttribution: pukku commentedHi! Thanks for this — I will look it over and see if I understand it. I initially used plain
eval
in this function; I switched over todrupal_eval
because it seemed safer, but I didn't realize that it would keep$r
from being available.Thanks,
Ricky
Comment #2
mbria CreditAttribution: mbria commentedI just found this same issue.
After patching your module could be nicely combined with "gtspam" to obfuscate mails in just a single line.
Evaluate this: return(gtspam($r['@mail']));
If you don't know your field name, give a try to: return(var_export($r));
Obviously gtspam module need to be installed and enabled. :-)
Thanks you guys for the great module and the patch.
Comment #3
roychri CreditAttribution: roychri commentedThank you cwells for your patch.
There is a few things I dislike about your patch.
Here is a patch which is less code change, reuse the existing drupal_eval() and only allow access to the $r array.
Let me know what you think.
Comment #4
chrisfromredfinI just looked at the patches real quick. This is sure a blast from the past, but if roychri's patch also works, it's a much better solution.
Comment #5
roychri CreditAttribution: roychri commentedHere is an updated patch for the version 6.x-1.0-beta1 version.
Anyone else want to review and mark as RTBC?
Thanks.
Comment #6
pooneil CreditAttribution: pooneil commentedHi cwells,
I applied the patch provided by roychri. I gave it a quick test and accessing the '$r' array works. The change is committed and should show up in the next release.
Regards,
Anthony
Comment #7
pooneil CreditAttribution: pooneil commented