This is probably a terrible idea.
It probably will not work.

But I got bored at the end of my flight home from BADCamp, so here's what I have.

CommentFileSizeAuthor
#1 vdc-1833872-1.patch5.7 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
Issue tags: +VDC
FileSize
vdc-1833872-1.patch5.7 KB

:D / :(

Status: Needs review » Needs work

The last submitted patch, vdc-1833872-1.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

To be honest, this seems to be something for contrib, but i guess parts of it are worth to include,
for example the change in the ViewEditFormController

+  if ($form_state['values']['ui_show_listing_filters'] != $config->get('fieldable')) {

This seems to be wrong :)

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

Yeah, I wouldn't plan on actually enabling this from within core, this would be just to ensure that it's possible.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Title: Allow Views to be fieldable » Allow ConfigEntity types to be fieldable
Assigned: tim.plunkett » Unassigned
Status: Needs work » Closed (won't fix)

Reasons this is won't fix:

  • field_has_data() assumes a base table, ConfigEntities don't have one
  • field_sql_storage_field_storage_write() assumes an integer entity ID, ConfigEntities have machine names
  • ConfigStorageController::invokeHooks() doesn't invoke field_attach_*() hooks
  • It's probably a bad idea.
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

That is, unless someone writes a field storage backend to write to YAML, or we just shove the fields in there ourselves...

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Closed (won't fix) » Postponed

#1846454: Add Entity query to Config entities might make this possible.

chx’s picture

chx CreditAttribution: chx commented
Status: Postponed » Closed (won't fix)

It's not enough. That issue uses ->get() now so it could grab some fields but the code for full field support with delta and columns is not there. And, it does not address all the other problems.