Hi,
I'm detecting a malfunction of link status in a view and I don`t kwon if I'm doing something wrong with the view or the code in views_handler_field_user_relationships_status_link.inc file is incorrect.

In line 45

//Requests by me.
    if ($values->{$this->aliases['requester_id']} === $user->uid) {
      if ($values->{$this->aliases['approved']}) {
        return theme('user_relationships_remove_link', array('uid' => $values->{$this->aliases['requestee_id']}, 'rid' => $values->{$this->aliases['rid']})) ;
      }
      else {
        return theme('user_relationships_pending_request_cancel_link', array('uid' => $values->{$this->aliases['requestee_id']}, 'rid' => $values->{$this->aliases['rid']})) ;
      }
    }

But I think it should be

//Requests by me.
    if ($values->{$this->aliases['requester_id']} === $user->uid) {
      if ($values->{$this->aliases['approved']}) {
        return theme('user_relationships_remove_link', array('uid' => $values->{$this->aliases['requesteer_id']}, 'rid' => $values->{$this->aliases['rid']})) ;
      }
      else {
        return theme('user_relationships_pending_request_cancel_link', array('uid' => $values->{$this->aliases['requesteer_id']}, 'rid' => $values->{$this->aliases['rid']})) ;
      }
    }

Am I wrong?

PS. Sorry for my english

Files: 
CommentFileSizeAuthor
#5 user_relationships-status_link-1834500-3.patch1.28 KBJvE
PASSED: [[SimpleTest]]: [MySQL] 1,047 pass(es).
[ View ]
#4 user_relationships-status_link-1834500-3.patch1.28 KBJvE
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch user_relationships-status_link-1834500-3_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 user_relationships-status_link-1834500-3.patch1.28 KBJvE
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch user_relationships-status_link-1834500-3.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Ups ...

NOT -> requesteer_id
YES -> requester_id

Hi,

I just posted: http://drupal.org/node/1838248#comment-6769138 regarding this issue which I see you also posted there.
I made the change you suggested above and it seems to have solved the issue however, I would need to do more testing and am curious if this will cause any issues anywhere else?

Has anyone else looked in to this issue?

Thanks.

Status:Active» Needs review
StatusFileSize
new1.28 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch user_relationships-status_link-1834500-3.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

I know that in #1838248: Status link not working correctly in user browser view a different approach is being followed, but for convenience I'm adding the simple patch for whoever wants to use it.

StatusFileSize
new1.28 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch user_relationships-status_link-1834500-3_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

I know a different approach is being followed in #1838248: Status link not working correctly in user browser view but I thought I'd upload the simple patch here too'

Version:7.x-1.0-alpha4» 7.x-1.x-dev
StatusFileSize
new1.28 KB
PASSED: [[SimpleTest]]: [MySQL] 1,047 pass(es).
[ View ]

Attaching a simple patch taking a different approach than #1838248: Status link not working correctly in user browser view