I was giving a site editor access to the admin menu so they can edit content and people and they got one link to edit the gcal events module settings. I checked the access arguments and its set to 'access administration pages' I would think the more appropriate access would be site configuration. I can give a site editor access to limited items on the admin pages but I don't want them to have access to the gcal events module settings which I would classify as administer site configuration. So I recommend this change in gcal_events_menu()
'access arguments' => array('administer site configuration'),

Even better would be to create a new permission access and let it be chosen via permissions who can see & configure it.

Comments

jdwfly’s picture

jdwfly CreditAttribution: jdwfly commented

Actually it would seem that the current permission gives more limited access than what you propose. There is a warning on the 'administer site configuration' one that it should only be given to trusted users. Of course I could just create a new permission for Gcal_events and then this would not be a problem.

  • jdwfly committed ca6ca8b on 7.x-1.x 
    Issue #1834788 by jdwfly: added a permissions to administrate...
jdwfly’s picture

jdwfly CreditAttribution: jdwfly commented
Issue summary: View changes
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.