Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up
Run jshint on the files with the configuration from the parent issue or use jshint.com with the following options:
/*jshint forin:true, noarg:true, eqeqeq:true, undef:true, curly:true, browser:true, expr:true, latedef:true, newcap:true, trailing:true */
/*global drupal, jQuery */
Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionality.
Create patch and upload for the testbot.
Files: modules/views/js/ajax_view.js
Comment | File | Size | Author |
---|---|---|---|
#7 | core-js-jshint-views-ajax-view-drupal.patch | 1.22 KB | rballou |
#1 | core-js-jshint-views-ajax-view.patch | 4.89 KB | rballou |
Comments
Comment #1
rballou CreditAttribution: rballou commentedOriginal set of errors:
The attached patch cleans up all of the issues listed.
Comment #2
rballou CreditAttribution: rballou commentedComment #3
nod_Oh crap, there was a problem with config and what we have.
drupal was thought to be introduced by a patch but it never went anywere. We should be using
Drupal
, notdrupal
, I updated the JSHint issue.Sorry about that :(
Comment #4
rballou CreditAttribution: rballou commentedNo worries. I will go back and change that!
Comment #5
tim.plunkettComment #6
tim.plunkettTagging VDC as well.
Comment #7
rballou CreditAttribution: rballou commentedAttaching the updated patch without the Drupal name change.
Comment #8
rballou CreditAttribution: rballou commentedForgot status change.
Comment #9
nod_Works for me :)
Comment #10
webchickCommitted and pushed to 8.x. Thanks!