Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up

Run jshint on the files with the configuration from the parent issue or use jshint.com with the following options:

/*jshint forin:true, noarg:true, eqeqeq:true, undef:true, curly:true, browser:true, expr:true, latedef:true, newcap:true, trailing:true */
/*global drupal, jQuery */

Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionality.
Create patch and upload for the testbot.

Files: modules/views/js/views-contextual.js

CommentFileSizeAuthor
#2 core-js-jshint-views-views-contextual.patch535 bytesrballou
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rballou’s picture

rballou CreditAttribution: rballou commented

Initial pass for JSHint:

views-contextual.js: line 9, col 1, 'Drupal' is not defined.

1 error
rballou’s picture

rballou CreditAttribution: rballou commented
Status: Active » Needs review
FileSize
core-js-jshint-views-views-contextual.patch535 bytes

This change has been made with the attached patch.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Closed (works as designed)

You copied drupal, not Drupal, so the code is actually correct.