Automated tests failing - Exception thrown in Date2 migration

Maybe related to #1778952: Fatal errors caused by auto-registration in some environments?

An improved version of patch from #1832544: Class registration for Migrate 2.5 or later: it completely eliminates the problem with current Simpletest-test, while that patch does not. See below:

• Proof that patch from #1832544: Class registration for Migrate 2.5 or later breaks: https://travis-ci.org/PatchRanger/drupal7-date/builds/6856298#L129
• Proof that this patch fixes: https://travis-ci.org/PatchRanger/drupal7-date/builds/6858903#L115

Interdiff is attached.

I've decided to re-roll the patch, giving credits in commit message to the creator of original patch.

Better to register the example migration via hook_migrate_api().

Better to register the example migration via hook_migrate_api().

It is registered (as you could see) - but it doesn't work for fixing this issue. Please take a look at the links I provided: they prove that these changes to your original patch are really important and necessary.
Changing back to 'needs review'.
Changing back to 'critical' also, because it is a show-stopper for entire Date issue queue, isn't it?

It's up to the Date maintainers, ultimately, but I don't believe a falsely-failing test is "critical".

If fixing the tests is considered an essential part of the original issue, then that should be done in the original issue, with this issue closed as a duplicate.

What I'm saying is that hook_migrate_api() is a preferable means of registering static migrations like this, registerMigration would be used when you're dynamically creating migrations (as from a UI).

... but I don't believe a falsely-failing test is "critical".

I doubt it is surprise to you that failing branch makes all submitted patches 'postponed' until it gets fixed. So the entire development process of Date module depends on this issue - that's why it is critical.

If fixing the tests is considered an essential part of the original issue, then that should be done in the original issue, with this issue closed as a duplicate.

My goal was to fix Simpletest-tests, because my recent patch is stuck (see #1365516: Start date is not excluded when an exception for it is set for reference). Your patch became a part of final solution. The result has been posted here - and your issue was closed as a duplicate, because it has only part of the solution. It is reasonable, isn't it?

What I'm saying is that hook_migrate_api() is a preferable means of registering static migrations like this, registerMigration would be used when you're dynamically creating migrations (as from a UI).

You're definitely, completely, ultimately right. I know it too. But it doesn't work without this hook: it should, but it doesn't - let's think why it happens. Any suggestions?

I'll try this out tonight. I realize it might not be the 100% best way, but we need the branch tests to pass.

@tim.plunkett Any update please? It is very important, because it makes testbot stuck.

This patch has been incorporated into the consolidated patch at #2034231: [META] Integrated patch for migration changes.